Opened 14 years ago

Closed 14 years ago

#23751 closed defect (fixed)

Incorrect dependencies for hgsubversion

Reported by: macports.org@… Owned by: akitada@…
Priority: Normal Milestone:
Component: ports Version: 1.8.2
Keywords: Cc:
Port: py26-hgsubversion

Description (last modified by mf2k (Frank Schima))

hgsubversion's dependencies are currently specified as py26-setuptools and subversion.

These are incorrect for 3 reasons:

  • py26-setuptools is nice but not actually mandatory, hgsubversion correctly falls back on regular distutils
  • mercurial is left out of the equation, while the setup.py will install it due to using setuptools, I believe it would be more sensible to make hgsubversion depend on mercurial.
  • As is, the installation of hgsubversion will break:
--->  Computing dependencies for py26-hgsubversion
--->  Building py26-hgsubversion
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_python_py26-hgsubversion/work/hgsubversion-1.0" && /opt/local/Library/Frameworks/Python.framework/Versions/2.6/bin/python2.6 setup.py --no-user-cfg build " returned error 1
Command output: Traceback (most recent call last):
  File "setup.py", line 96, in <module>
    raise Exception('You need to install the SWIG'
Exception: You need to install the SWIG bindings for Subversion to use this package.

Error: Status 1 encountered during processing.
Before reporting a bug, first run the command again with the -d flag to get complete output.

hgsubversion needs to depend on subversion-python26bindings in order to build correctly. As a result, it does *not* need to depend on subversion at all.

Suggested dependency changes:

  • + add mercurial
  • + add subversion-python26bindings
  • - remove py26-setuptools
  • - remove subversion

Change History (3)

comment:1 Changed 14 years ago by mf2k (Frank Schima)

Cc: akitada@… removed
Keywords: py26-hgsubversion removed
Owner: changed from macports-tickets@… to akitada@…
Port: py26-hgsubversion added

comment:2 Changed 14 years ago by mf2k (Frank Schima)

Description: modified (diff)

comment:3 Changed 14 years ago by akitada@…

Resolution: fixed
Status: newclosed

Fixed in r64032. Thanks for reporting.

Note: See TracTickets for help on using tickets.