php5-xhprof including supplied PHP classes

[rodney.rehm@…]

While playing around with this PECL I noticed some crucial parts missing. The PECL comes bundled with some PHP files, that actually make up the UI.

I'm not quite sure if I put the things in the right places, though. Since xhprof has an optional graph based on graphviz, I added a variant that will also patch the respective file with the path to the dot binary. I don't know what this will do to installations not residing in /opt/local, though.

[rodney.rehm@…]

changes made to original Portfile

[rodney.rehm@…]

patch applied for variant graphviz

[ryandesign (Ryan Carsten Schmidt)]

Thanks, committed in r65275 with these changes:

• "depends_lib-delete" in the graphviz variant should have been "depends_lib-append"
• "port:graphviz" in the graphviz variant should be "path:bin/dot:graphviz" so that graphviz-devel could also satisfy the dependency
• I used "patchfiles-append" instead of just "patchfiles" in the graphviz variant so that, although there aren't any now, if any patchfiles are later added to the port globally, the graphviz variant won't then override them
• I changed the patchfile name to begin with "patch-"
• Fixed the patch so it will work regardless of the user's ${prefix}
• In the post-destroot, you have to do things inside ${destroot}, not directly in ${prefix}, otherwise the items don't get registered to the port, as you can confirm by running "port contents"
• In the post-destroot, I switched to "xinstall -d" for making the directory, since I prefer to use xinstall in the destroot phase, and switched from "file copy" to just "copy" since that's shorter and synonymous
• I moved the post-destroot and graphviz variant above the livecheck line; I like to keep the livecheck as the last thing in a portfile

[ryandesign (Ryan Carsten Schmidt)]

Replying to ryandesign@…:

• "depends_lib-delete" in the graphviz variant should have been "depends_lib-append"

Correction: at the last minute I changed it to "depends_run-append" since it doesn't really check for graphviz at build time, I think, but only uses it at runtime.

[rodney.rehm@…]

Sweet mother?! Thanks for the quick fix and that heavy rewriting :)

If there was an apache2 variant, that would trigger some nice vHost handling (specifically like gentoo does the job), we could also supply ports like this (and phpmyadmin and ...) with an apache2-vhost variant, which would make the ever-the-same-setup-of-stupid-little-vhosts obsolete. has anyone ever thought about this, or do you guys just throw everything into the default host?

[ryandesign (Ryan Carsten Schmidt)]

Feel free to discuss that on the mailing list; it probably doesn't belong in this ticket.