Opened 14 years ago

Closed 14 years ago

#24901 closed enhancement (fixed)

google-collections: simplify

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: blair (Blair Zajac)
Priority: Normal Milestone:
Component: ports Version: 1.8.2
Keywords: Cc:
Port: google-collections

Description

I noticed google-collections can be simplified in a few ways.

The distfiles line can be removed because you're already setting distname and use_zip.

And the two xinstalls in the destroot phase that make the directories can be combined into one. And the -m 755 modifier can be deleted because that is the default mode.

The attached patch makes these changes.

Attachments (1)

google-collections.diff​ (779 bytes) - added by ryandesign (Ryan Carsten Schmidt) 14 years ago.
proposed patch

Download all attachments as: .zip

Change History (2)

Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: google-collections.diff​ added

proposed patch

comment:1 Changed 14 years ago by blair (Blair Zajac)

Resolution: → fixed
Status: new → closed

Thanks, fixed in r67680 and r67681.

Note: See TracTickets for help on using tickets.