Opened 6 years ago

Closed 6 years ago

#25257 closed defect (fixed)

libmcs: fix library install_name and versions

Reported by: ryandesign (Ryan Schmidt) Owned by: jdunn@…
Priority: Normal Milestone:
Component: ports Version: 1.9.0
Keywords: Cc:
Port: libmcs

Description

This patch fixes libmcs.dylib's install_name, compatibility version and current version. Before this patch:

$ otool -L /opt/local/lib/libmcs.dylib
/opt/local/lib/libmcs.dylib:
	libmcs.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 125.0.1)
	/opt/local/lib/libmowgli.dylib (compatibility version 0.0.0, current version 0.0.0)

After this patch:

$ otool -L /opt/local/lib/libmcs.dylib
/opt/local/lib/libmcs.dylib:
	/opt/local/lib/libmcs.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 125.0.1)
	/opt/local/lib/libmowgli.dylib (compatibility version 0.0.0, current version 0.0.0)

This patch includes a few changes from upstream:

It also undoes part of this upstream change:

I don't understand that change. I don't know what -rpath is all about. And we don't have any ports that depend on libmcs to see if they work properly without my patch. But it seems to me that without -install_name, the library's install_name is not correct. So I brought that part back.

Attachments (1)

libmcs-install_name.diff (2.2 KB) - added by ryandesign (Ryan Schmidt) 6 years ago.
proposed patch

Download all attachments as: .zip

Change History (6)

comment:1 follow-up: Changed 6 years ago by jdunn@…

audacious media player http://audacious-media-player.org/ depends on libmcs, but i failed to get it working correctly as only version 2.2 would compile but not run, so i gave up on that Portfile. Otherwise im not sure.

Changed 6 years ago by ryandesign (Ryan Schmidt)

proposed patch

comment:2 Changed 6 years ago by ryandesign (Ryan Schmidt)

I meant to add these notes:

Replying to ryandesign@…:

This patch fixes libmcs.dylib's install_name

This patch assumes the patch from #25256 has already been applied.

This seems like a good idea to add.

I don't totally understand these changes but I suppose they may as well be added.

comment:3 in reply to: ↑ 1 Changed 6 years ago by ryandesign (Ryan Schmidt)

Replying to jdunn@…:

audacious media player http://audacious-media-player.org/ depends on libmcs, but i failed to get it working correctly as only version 2.2 would compile but not run, so i gave up on that Portfile.

Could you submit your attempted portfile in a new ticket? Maybe I can have a look and make it work.

comment:4 Changed 6 years ago by jdunn@…

the patch seems to work great.

comment:5 Changed 6 years ago by ryandesign (Ryan Schmidt)

  • Resolution set to fixed
  • Status changed from new to closed

Ok, it's committed in r68832.

Note: See TracTickets for help on using tickets.