mutt-devel : cannot compile ssl

[erwan@…]

when upgrading mutt_devel from 1.5.20_2 to 1.5.20_3, it fail to compile mutt_ssl.c with following error

/usr/bin/gcc-4.0 -DPKGDATADIR=\"/opt/local/share/mutt\" -DSYSCONFDIR=\"/opt/local/etc\" -DBINDIR=\"/opt/local/bin\" -DMUTTLOCALEDIR=\"/opt/local/share/locale\" -DHAVE_CONFIG_H=1 -I.  -I. -I. -I./imap -I/opt/local/include -I/opt/local/include -Iintl -I/opt/local/include -I/opt/local/include -I/opt/local/include -I/opt/local/include -I/opt/local/include -I./intl  -O2 -arch i386 -MT mutt_ssl.o -MD -MP -MF .deps/mutt_ssl.Tpo -c -o mutt_ssl.o mutt_ssl.c
mutt_ssl.c: In function 'check_host':
mutt_ssl.c:655: error: 'STACK' undeclared (first use in this function)
mutt_ssl.c:655: error: (Each undeclared identifier is reported only once
mutt_ssl.c:655: error: for each function it appears in.)
mutt_ssl.c:655: error: 'subj_alt_names' undeclared (first use in this function)
mutt_ssl.c: In function 'ssl_cache_trusted_cert':
mutt_ssl.c:738: warning: assignment from incompatible pointer type
make[2]: *** [mutt_ssl.o] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

used variants are mutt-devel @1.5.20_2+compress+gpgme+headercache+imap+pop+sasl+smtp+ssl+tokyocabinet

[erwan@…]

Cc Me!

[bwalle (Bernhard Walle)]

Cc Me!

[jmroot (Joshua Root)]

Please remember to cc the maintainer, and note that you do not need to be in cc when you are the reporter.

[jmroot (Joshua Root)]

Patch that PLD Linux used: ​http://www.mail-archive.com/pld-cvs-commit@lists.pld-linux.org/msg216106.html

[erwan@…]

I also upgradede openssl (0.9.8 -> 1.0.0) during this upgrade session. Might it be related ?

[rcobbe]

Cc Me!

[mike@…]

Cc Me!

[mike@…]

Fails on a fresh macports install too (mutt-devel +ssl, openssl 1.0.0).

$ port -vv install mutt-devel +ssl

...

/usr/bin/gcc-4.2 -pipe -O2 -arch x86_64 -L/opt/local/lib -arch x86_64 -L/opt/local/lib -L/opt/local/lib -L/opt/local/lib -o pgpewrap pgpewrap.o wcscasecmp.o -lintl -liconv mutt_ssl.c: In function 'check_host': mutt_ssl.c:655: error: 'STACK' undeclared (first use in this function) mutt_ssl.c:655: error: (Each undeclared identifier is reported only once mutt_ssl.c:655: error: for each function it appears in.) mutt_ssl.c:655: error: 'subj_alt_names' undeclared (first use in this function) mutt_ssl.c: In function 'ssl_cache_trusted_cert': mutt_ssl.c:738: warning: assignment from incompatible pointer type make[2]: * [mutt_ssl.o] Error 1 make[2]: * Waiting for unfinished jobs.... mv -f .deps/sha1.Tpo .deps/sha1.Po mv -f .deps/pgppubring.Tpo .deps/pgppubring.Po make[1]: * [all-recursive] Error 1 make: * [all] Error 2 shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_mail_mutt-devel/work/mutt-1.5.20" && /usr/bin/make -j4 all " returned error 2

[rbgarga@…]

Cc Me!

[dmitry@…]

Cc Me!

[dmitry@…]

Cc Me!

[dmitry@…]

Okay, I pulled the patch off of the freebsd ports mailing list

[0] ​http://www.freebsd.org/cgi/query-pr.cgi?pr=146261

I think this is more accurate, than the one listed above.

And just in case anyone is burning to apply this patch, here's how to do it:

$ cd /opt/local/var/macports/sources/rsync.macports.org/release/ports/mail/mutt-devel $ sudo patch -p1 < /path/to/patch $ sudo port install mutt-devel +ssl [+others]

At this point, it should notice that the Portfile has been incremented, and you should be good to go!

Wouldn't mind some feedback too ;)

[mike@…]

Patch (and instructions!) worked for me. +1.

[rbgarga@…]

Worked fine for me too, thanks!

[kuperman@…]

I'll confirm that this patch works for me as well. I use

mutt-devel @1.5.20_3+compress+gdbm+headercache+imap+pop+sasl+smtp+ssl+trash (active)

BTW, you can simplify getting to the proper folder to apply the patch using the following instead of the first command:

cd `port dir mutt-devel`

I've found that particular port command quite handy when tweaking Portfiles.

Thanks for this fix!

[rbgarga@…]

Cc Me!

[erwan@…]

Works for me also. Great job.

[mike@…]

Cc Me!

[drkp (Dan Ports)]

Cc Me!

[dmitry@…]

Same patch, but increment the revision in the portfile (no need to apply this one, if you've applied the previous one)

[dmitry@…]

So i took another glance over my "patch" just to make sure I didn't mess anything up (it was 2AM for me). From my point of view everything looks good.

No need to thank me, this really is simply the fix from FreeBSD MLs... and for those of you who haven't actually looked in the patch i invite you to. You'll see that in line 43 the fix is just ONE line. I guess it shouldn't suprise anyone since all that happened is it got broken by a dependency.

Anyway I also increased the revision number (which i forgot before), so it's good to go now! All the devs have to do is apply it to the port system :)

[drkp (Dan Ports)]

Works for me too -- and now committed in r69763. Thanks for finding the patch!

[derekathomas@…]

Cc Me!