Opened 11 years ago

Closed 10 years ago

#25779 closed update (fixed)

qiv: update to version 2.2.3

Reported by: someuser12 Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.9.1
Keywords: haspatch Cc: lloyd@…, dwhit@…
Port: qiv

Description

Please find attached a patch to the Portfile of qiv to move to the upstream version 2.2.3 (including the new maintainer's website and a livecheck feature) and an updated patch.

Attachments (4)

patch-Makefile.diff (1.1 KB) - added by someuser12 10 years ago.
New patch for qiv version 2.2.3
patch-Portfile (1.4 KB) - added by someuser12 10 years ago.
Patch to the Portfile of qiv, updating from version 2.0 to 2.2.3
patch-Portfile.2 (796 bytes) - added by someuser12 10 years ago.
Patch to the Portfile of qiv version 2.2.3, adding the gtk2 dependency and the libmagic variant
patch-Portfile.3 (406 bytes) - added by someuser12 10 years ago.
Patch to the Portfile of qiv version 2.2.3, adding the gtk2 dependency

Download all attachments as: .zip

Change History (16)

comment:1 Changed 11 years ago by ryandesign (Ryan Schmidt)

Cc: lloyd@… added

Cc'ing maintainer for evaluation.

Note your patchfile has a small mistake: "/opt/local" should go back to being "@PREFIX@" like it is in the current patchfile.

comment:2 Changed 11 years ago by ryandesign (Ryan Schmidt)

Note also the line "distfiles ${name}-${version}.tgz" should be deleted and replaced with the simpler "extract.suffix .tgz"

comment:3 in reply to:  description Changed 10 years ago by someuser12

Thank you for your corrections. I'm attaching a new patch to the Portfile and a new patch file to take them into account and to provide the libmagic variant (instead of completely switching off the use of libmagic, now the Portfile has it as an option).

With this variant, qiv is able to correctly display (at least part of) the image files that miss a correct extension but that file is able to recognize. I tested qiv with and without the variant on Mac OS X 10.5.8 .

To do, maybe: copy qiv-command.example into /opt/local/share/doc/qiv (and create that directory) or install a default qiv-command into /opt/local/bin. But anyway the installation process outputs a comment on this file.

Changed 10 years ago by someuser12

Attachment: patch-Makefile.diff added

New patch for qiv version 2.2.3

comment:4 Changed 10 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added
Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned
Summary: Update proposal of qiv to version 2.2.3qiv: update to version 2.2.3

comment:5 Changed 10 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

Since the maintainer has not responded, I committed a version of your patch in r77387 and r77388. You mentioned having attached a new version that had a libmagic variant, but the files attached here don't seem to have that. Instead, I just left magic support enabled all the time.

comment:6 Changed 10 years ago by dwhit@…

Resolution: fixed
Status: closedreopened

The new version of the port now has an undeclared dependency on gtk2. Attempts to install without first installing gtk2 fail.

Changed 10 years ago by someuser12

Attachment: patch-Portfile added

Patch to the Portfile of qiv, updating from version 2.0 to 2.2.3

comment:7 Changed 10 years ago by someuser12

I'm terribly sorry, it seems I forgot in last August to attach the patch with the libmagic variant, which incidentally also declared the dependency on gtk2. Here it is now. I ckeched that the current version of qiv is still 2.2.3, so the patch is not outdated.

comment:8 Changed 10 years ago by ryandesign (Ryan Schmidt)

It would be more helpful if you could supply a patch against the current version of the portfile in the repository, which has already been updated to 2.2.3.

Changed 10 years ago by someuser12

Attachment: patch-Portfile.2 added

Patch to the Portfile of qiv version 2.2.3, adding the gtk2 dependency and the libmagic variant

comment:9 Changed 10 years ago by someuser12

Here it is. Thank you!

comment:10 Changed 10 years ago by ryandesign (Ryan Schmidt)

Why do we want to add a libmagic variant? Why not just enable this functionality all the time, as the port currently does?

comment:11 Changed 10 years ago by someuser12

I think this was to allow one to tune the behaviour; the default variant would make the package minimal (add a dependence against the 'file' port only if needed) and the libmagic variant would add the functionality. But we can enable it all the time or add a variant "without-libmagic".

I attach a patch to the repository Portfile to add the gtk2 dependence (leaving libmagic always on).

Changed 10 years ago by someuser12

Attachment: patch-Portfile.3 added

Patch to the Portfile of qiv version 2.2.3, adding the gtk2 dependency

comment:12 Changed 10 years ago by ryandesign (Ryan Schmidt)

Cc: dwhit@… added
Resolution: fixed
Status: reopenedclosed

I added the gtk2 dependency in r77785. I'll leave magic support always on, since the file dependency is not large and takes less than a minute to build.

Note: See TracTickets for help on using tickets.