Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#25866 closed submission (fixed)

MetaPixel

Reported by: fclaire@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.9.1
Keywords: Cc:
Port: metapixel

Description

Hi,

Please find attached my submission of the metapixel port.

More info on metapixel here: http://www.complang.tuwien.ac.at/schani/metapixel/

Attachments (2)

Portfile (1.3 KB) - added by fclaire@… 14 years ago.
patch-Makefile.diff (1.1 KB) - added by fclaire@… 14 years ago.

Download all attachments as: .zip

Change History (11)

Changed 14 years ago by fclaire@…

Attachment: Portfile added

Changed 14 years ago by fclaire@…

Attachment: patch-Makefile.diff added

comment:1 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

comment:2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Thanks. I committed the port in r70109 with many changes:

  • whitespace changes and reformatting
  • fixing what "port lint" pointed out ("use_configure no" instead of "configure {}")
  • fixing the maintainer line (since you are not a committer, needs to be your full email address, or its obfuscated form, as I used here)
  • support for universal builds and non-default-build_arch builds
  • not linking with non-MacPorts libs (removing /usr/X11R6 from Makefile)

comment:3 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

By the way, why did you include a dependency on port:perl5?

comment:4 Changed 14 years ago by fclaire@…

Well, in the package's README there is:


To compile Metapixel, you need, in addition to a C compiler, libpng, libjpeg, and giflib. To run the script for preparing constituent images, you will additionally need Perl.


So I just added all of them as dependency without verifying if it was indeed required.

It's the first time I do a Portfile so thank you for the corrections you've done - I'm learning.

I successfully tested the program on a MacBook Pro with Snow Leopard 10.6.4 and on a Mac Mini with Snow Leopard Server 10.6.4

comment:5 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

I figured that might be it, but you'll note that the first line of those scripts refers to /usr/bin/perl, which is the perl already included in every copy of Mac OS X. So either we leave it that way and remove the port:perl5 dependency, or we switch the shebang line of those scripts to point to ${prefix}/bin/perl and keep the dependency. But I'm guessing the perl already on Mac OS X is sufficient.

comment:6 Changed 14 years ago by fclaire@…

Yes, let's remove this dependency. Some people might want to use metapixel only and wouldn't like to get the whole perl5 macports package(s) installed on their Mac together with the Mac OS X perl.

Another point: why did you create the patch-rwimg-Makefile.diff ? I didn't got any problem compiling with the original one.

comment:7 in reply to:  6 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to fclaire@…:

Yes, let's remove this dependency. Some people might want to use metapixel only and wouldn't like to get the whole perl5 macports package(s) installed on their Mac together with the Mac OS X perl.

Done in r70134.

Another point: why did you create the patch-rwimg-Makefile.diff ? I didn't got any problem compiling with the original one.

I wanted to add universal support but universal builds failed without this patch.

comment:8 Changed 14 years ago by fclaire@…

Ok, great stuff.

Now for the future I'm wondering who'll maintain this package: you or myself ?

I don't believe there'll be much to do as the development is stalled since 2006. So I'd be OK to handle this if I could get some help on how to update the Portfile and add/modify patches in the central macports repository.

comment:9 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

You had yourself listed as the maintainer in the port when you submitted it, so you're it. If you want to make changes to the port, file a new ticket in this issue tracker and attach your diff and someone will review and commit it. If you'd like to allow others to make changes to the port without having to ask your permission first, we can add the "openmaintainer" keyword to the port.

Note: See TracTickets for help on using tickets.