Opened 14 years ago

Closed 5 years ago

#26454 closed update (fixed)

Update for tovid to version 0.33

Reported by: danielb@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Port: tovid

Description

Hello all I am attempting to update the tovid port to version 0.33 which has some python dependencies, etc. I have a few issues with how it's building and this is my first stab at writing a Portfile. If add this line I can get tovid to actually install and run properly:

+destroot.destdir --prefix=${prefix} --root=${destroot}

However it installs all the python modules to /opt/local/lib/python2.6/site-packages which is not in sys.path so running 'tovid gui' fails to find libtovid.guid module.

If I remove this line it will install everything in the long "framework" path but then the 'tovid' binary fails to find the shell scripts and it names it to tovid-2.6 which is silly. I believe the binary is expecting the bash script to be located in ${prefix}/lib or what not. So in essence I am looking for the proper way to use the python port group and get this running. Any guidance would be appreciated.

I've also patched the source to use the 'g' prefix utils in coreutils which I have attached. Finally, as soon as I get the build things worked out the last item would be to replace the Linux specific bash code that gleams info out of /proc/cpuinfo with proper sysctl calls that is portable across the supported OS X versions. I may be getting some help on those patches but I am pretty confident that I can fix that portion of the code myself if needed.

Any help or suggestions would be appreciated. I am going to keep plugging away.

Thank you,

Dan (a.k.a., chillywilly on #macports)

Attachments (24)

cpuinfo-tovid-init.in.diff (885 bytes) - added by danielb@… 14 years ago.
cpuinfo-tovid.diff (429 bytes) - added by danielb@… 14 years ago.
patch-src-tovid-init.in.diff (1.2 KB) - added by danielb@… 14 years ago.
patch-src-tovid-init.diff (1.2 KB) - added by danielb@… 14 years ago.
patch-src-todisc.diff (19.3 KB) - added by danielb@… 14 years ago.
patch-src-makexml.diff (3.0 KB) - added by danielb@… 14 years ago.
patch-src-makempg.diff (5.1 KB) - added by danielb@… 14 years ago.
patch-src-makemenu.diff (874 bytes) - added by danielb@… 14 years ago.
patch-src-makedvd.diff (1.5 KB) - added by danielb@… 14 years ago.
patch-src-make_titlesets.diff (3.0 KB) - added by danielb@… 14 years ago.
patch-src-idvid.diff (4.6 KB) - added by danielb@… 14 years ago.
patch-libtovid-deps.py.diff (944 bytes) - added by danielb@… 14 years ago.
ffmpeg-flag-fix.diff (5.8 KB) - added by danielb@… 14 years ago.
Portfile-tovid.diff (3.6 KB) - added by danielb@… 14 years ago.
patch-libtovid-coreutils-bins.diff (988 bytes) - added by danielb@… 14 years ago.
patch-src-coreutils-bins.diff (40.0 KB) - added by danielb@… 14 years ago.
patch-cpuinfo-tovid-init.in.diff (885 bytes) - added by danielb@… 14 years ago.
patch-ffmpeg-flag-fix.diff (5.8 KB) - added by danielb@… 14 years ago.
Portfile-tovid.2.diff (3.6 KB) - added by danielb@… 14 years ago.
patch-src-coreutils.diff (41.1 KB) - added by danielb@… 14 years ago.
patch-cpuinfo-tovid-init.in.2.diff (1.3 KB) - added by danielb@… 14 years ago.
patch-libtovid-coreutils.diff (988 bytes) - added by danielb@… 14 years ago.
patch-cpuinfo-tovid.diff (429 bytes) - added by danielb@… 14 years ago.
patch-ffmpeg-pad-flag.diff (5.8 KB) - added by danielb@… 14 years ago.

Download all attachments as: .zip

Change History (36)

comment:1 Changed 14 years ago by danielb@…

I think I may create one patch file for all this stuff at some point. Was a pain to attach all these files.

comment:2 Changed 14 years ago by danielb@…

Cc: danielb@… added

Cc Me!

comment:3 in reply to:  description Changed 14 years ago by danielb@…

Replying to danielb@…:

I think I know how to get this to work without the destroot.destdir line but I am still trying to figure out how this things works. I need to link the scripts to:

${prefix}/lib/${name}

I am just not sure what commands to use at this point or where to call them from...I am thinking post-destroot? I am struggling with trying to figure out the difference between ${worksrcpath}, ${desroot}, and ${prefix}....help? :)

Hello all I am attempting to update the tovid port to version 0.33 which has some python dependencies, etc. I have a few issues with how it's building and this is my first stab at writing a Portfile. If add this line I can get tovid to actually install and run properly:

+destroot.destdir --prefix=${prefix} --root=${destroot}

However it installs all the python modules to /opt/local/lib/python2.6/site-packages which is not in sys.path so running 'tovid gui' fails to find libtovid.guid module.

If I remove this line it will install everything in the long "framework" path but then the 'tovid' binary fails to find the shell scripts and it names it to tovid-2.6 which is silly. I believe the binary is expecting the bash script to be located in ${prefix}/lib or what not. So in essence I am looking for the proper way to use the python port group and get this running. Any guidance would be appreciated.

I've also patched the source to use the 'g' prefix utils in coreutils which I have attached. Finally, as soon as I get the build things worked out the last item would be to replace the Linux specific bash code that gleams info out of /proc/cpuinfo with proper sysctl calls that is portable across the supported OS X versions. I may be getting some help on those patches but I am pretty confident that I can fix that portion of the code myself if needed.

Any help or suggestions would be appreciated. I am going to keep plugging away.

Thank you,

Dan (a.k.a., chillywilly on #macports)

comment:4 Changed 14 years ago by jmroot (Joshua Root)

Cc: danielb@… removed
Keywords: tovid 0.33 removed
Milestone: MacPorts 1.9.2
Owner: changed from macports-tickets@… to macports@…
Version: 1.9.1

As per the ticket guidelines linked from the New Ticket page, please don't set the Milestone field, and remember to cc the maintainer. You do not need to be in cc when you are the reporter.

comment:5 in reply to:  4 Changed 14 years ago by danielb@…

Replying to jmr@…:

As per the ticket guidelines linked from the New Ticket page, please don't set the Milestone field, and remember to cc the maintainer. You do not need to be in cc when you are the reporter.

I could not remove the milestone after I set it or I was unable to figure out how to remove it.

comment:6 Changed 14 years ago by danielb@…

I added a new Portfile. Not quite done yet. I am not sure whether the symlinking approach is a good idea or not. There's some other files that I left sitting in the python framework path as well.

Thoughts?

Changed 14 years ago by danielb@…

Attachment: cpuinfo-tovid-init.in.diff added

Changed 14 years ago by danielb@…

Attachment: cpuinfo-tovid.diff added

Changed 14 years ago by danielb@…

Changed 14 years ago by danielb@…

Attachment: patch-src-tovid-init.diff added

Changed 14 years ago by danielb@…

Attachment: patch-src-todisc.diff added

Changed 14 years ago by danielb@…

Attachment: patch-src-makexml.diff added

Changed 14 years ago by danielb@…

Attachment: patch-src-makempg.diff added

Changed 14 years ago by danielb@…

Attachment: patch-src-makemenu.diff added

Changed 14 years ago by danielb@…

Attachment: patch-src-makedvd.diff added

Changed 14 years ago by danielb@…

Changed 14 years ago by danielb@…

Attachment: patch-src-idvid.diff added

Changed 14 years ago by danielb@…

Attachment: patch-libtovid-deps.py.diff added

Changed 14 years ago by danielb@…

Attachment: ffmpeg-flag-fix.diff added

comment:7 Changed 14 years ago by danielb@…

Updated files to build tovid 033. This is very close to the final version. I need to do some more testing.

Changed 14 years ago by danielb@…

Attachment: Portfile-tovid.diff added

Changed 14 years ago by danielb@…

Changed 14 years ago by danielb@…

Changed 14 years ago by danielb@…

Changed 14 years ago by danielb@…

Attachment: patch-ffmpeg-flag-fix.diff added

comment:8 Changed 14 years ago by danielb@…

Added the following patches which are referenced in the new Portfile diff:

# Patch tovid scripts to use coreutils binaries: gdu, gsed, gmd5sum, and greadlink
# Patch ffmpeg flags w/ vendor patch and /proc/cpuinfo munging to use sysctl (contributed by drepper)
patchfiles        patch-libtovid-coreutils-bins.diff \
                  patch-src-coreutils-bins.diff \
                  patch-ffmpeg-flag-fix.diff \
                  patch-cpuinfo-tovid-init.in.diff \
                  patch-cpuinfo-tovid.diff

The rest of the patches can be removed. I do not have access to remove them.

Changed 14 years ago by danielb@…

Attachment: Portfile-tovid.2.diff added

Changed 14 years ago by danielb@…

Attachment: patch-src-coreutils.diff added

Changed 14 years ago by danielb@…

Changed 14 years ago by danielb@…

Changed 14 years ago by danielb@…

Attachment: patch-cpuinfo-tovid.diff added

Changed 14 years ago by danielb@…

Attachment: patch-ffmpeg-pad-flag.diff added

comment:9 Changed 14 years ago by danielb@…

Ok, Please see the last 6 patches that I have attached. I forgot to check the "overwrite if same file name button" a couple of times :-/. This is the final version of the port. I have other issues with transcode segfaulting when doing more sophisticated things with 'tovid disc', but I can at least create a DVD with a simple text menu. I am not sure what to do about the segfault issues in transcode, but that's not necessarily a tovid issue.

-Dan

comment:10 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports@… to macports-tickets@…

comment:11 Changed 5 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Cc: MarcusCalhoun-Lopez added

comment:12 Changed 5 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Resolution: fixed
Status: newclosed

In 691c4d612999c1985d69b59722027fc216f26c8b/macports-ports (master):

tovid: update version 0.31->0.35.2

  • add license
  • update dependencies
  • switch to GitHub

Fixes #26454
Fixes #33522
Fixes #24151
See #53467

Note: See TracTickets for help on using tickets.