avidemux 2.5.3 uses ffmpeg port headers instead of its own

[ak.ml@…]

avidemux 2.5.3 fails to build at 59%.

It looks like it tries to use the headers of the ffmpeg port rather than its own for some plugins.

When ffmpeg is deactivated, avidemux compiles fine.

MacIntel 10.5.8.

[raimue (Rainer Müller)]

The problem is, cmake always has -I/opt/local/include hardcoded and adds other paths specified with include_directories(...) at the end. Of course, this ends up in the wrong order, with -I/opt/local/include at the front while it should be the last.

I tried to fix this in r71635 by adding this flag to cmake, as ​described in their documentation:

-DCMAKE_INCLUDE_DIRECTORIES_BEFORE=ON

For me on Snow Leopard 10.6.4 using cmake @2.8.2_2+gui. ffmpeg @0.6_2 was active and installed at the same time, the build still was okay. But this could still mean it is picking up wrong headers :-)

And actually, you are right the order is still wrong even for me while building plugins:

...
-I/opt/local/include -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_multimedia_avidemux/work/avidemux_2.5.3/avidemux/ADM_libraries/ffmpeg
...

I am adding css@ as cmake maintainer to CC as he might have a hint where to look at for this problem. I am clueless at the moment...

[ak.ml@…]

Cc Me!

[cssdev]

Replying to raimue@…:

I tried to fix this in r71635 by adding this flag to cmake, as ​described in their documentation:

-DCMAKE_INCLUDE_DIRECTORIES_BEFORE=ON

I'm pretty sure that case is important. Try -DCMAKE_include_directories_BEFORE:BOOL=ON instead.

[raimue (Rainer Müller)]

Replying to css@…:

I'm pretty sure that case is important. Try -DCMAKE_include_directories_BEFORE:BOOL=ON instead.

Damn. Thank you for your help, this seems to solve the problem for me now even for the plugins.

Committed in r71689.

[ak.ml@…]

Damn. Thank you for your help, this seems to solve the problem for me now even for the plugins.

Committed in r71689.

I'm still having some issues compiling.

[ak.ml@…]

After r71689

[icemac (Michael Howitz)]

Cc Me!

[kato23@…]

The ​CMake 2.8 Documentation of 2012-03-30 apparently has switched back to CMAKE_INCLUDE_DIRECTORIES_BEFORE (from previous CMAKE_include_directories_BEFORE).

Editing the avidemux Portfile with respect to this change allows avidemux @2.5.3_7+aac+dts+lame+ogg+x264+xvid to build successfully on Mac OS X 10.6.8.

# edit the avidemux Portfile
cd "$(port dir avidemux)"
cat <<-'EOF' | sudo ed -s Portfile
H
/-DCMAKE_include_directories_BEFORE=ON/s//-DCMAKE_INCLUDE_DIRECTORIES_BEFORE=ON/
wq
EOF

(Deactivating an already installed ffmpeg port worked for me as well.)

(Note: I installed avidemux in a custom location as described in the MacPorts Guide, ​2.3.4. Install Multiple MacPorts Copies.)

[jmroot (Joshua Root)]

r92826