Opened 9 years ago

Closed 8 years ago

#26539 closed update (fixed)

update for wml-2.0.11

Reported by: reg-macports.org@… Owned by: neverpanic (Clemens Lang)
Priority: Normal Milestone:
Component: ports Version: 1.9.1
Keywords: Cc: hahn.seb@…
Port: wml

Description

The wml distribution includes some tools that are installed in PREFIX/lib/exec, which are duplicates of other ports. This patch removes these tools and replaces them with references to the other ports.

After all, de-duplication is what packaging systems are all about.


However, more importantly, it removes problems with two of these tools:

eperl:

is tricky to get to compile and work on MacOS X, see #23803 or #12582. Offloading this to a separate port (eperl, which I've submitted today, #26534) makes maintenance easier.

tidy:

has seen a lot of updates since its inclusion in the wml distribution. The version that comes with wml is very outdated and slightly incompatible. If you write Makefiles for Debian's wml (which just depends on the new tidy, too), they might be incompatible with MacPort's.


Unlike Debian's wml, the following packages are not yet de-duplicated as they haven't been packaged for MacPots:

  • iselect
  • mp4h
  • slice
  • linklint
  • freetable
  • weblint

Attachments (8)

Portfile (1.2 KB) - added by reg-macports.org@… 9 years ago.
updated Portfile
patch-configure (1.2 KB) - added by reg-macports.org@… 9 years ago.
patch-no_eperl (3.8 KB) - added by reg-macports.org@… 9 years ago.
patch-no_gm4 (3.2 KB) - added by reg-macports.org@… 9 years ago.
patch-no_tidy (4.6 KB) - added by reg-macports.org@… 9 years ago.
patch-no_txt2html (3.9 KB) - added by reg-macports.org@… 9 years ago.
Portfile.2 (1.3 KB) - added by reg-macports.org@… 8 years ago.
new version
files.zip (6.8 KB) - added by reg-macports.org@… 8 years ago.
new version

Download all attachments as: .zip

Change History (20)

Changed 9 years ago by reg-macports.org@…

Attachment: Portfile added

updated Portfile

Changed 9 years ago by reg-macports.org@…

Attachment: patch-configure added

Changed 9 years ago by reg-macports.org@…

Attachment: patch-no_eperl added

Changed 9 years ago by reg-macports.org@…

Attachment: patch-no_gm4 added

Changed 9 years ago by reg-macports.org@…

Attachment: patch-no_tidy added

Changed 9 years ago by reg-macports.org@…

Attachment: patch-no_txt2html added

comment:1 Changed 9 years ago by reg-macports.org@…

Cc: reg-macports.org@… added

Cc Me!

comment:2 Changed 8 years ago by hahn.seb@…

Cc: hahn.seb@… added

Cc Me!

comment:3 Changed 8 years ago by hahn.seb@…

This looks like a nice update, especially because recently wml has started failing due to errors in its components. Maybe you could check your patches to see if they fix those issues and then they could be submitted?

comment:4 Changed 8 years ago by reg-macports.org@…

The main problem is that eperl, whether integrated in wml or as a separate port, needs a +shared perl. There's no way around this.

Separating the package makes maintenance easier, though.

Changed 8 years ago by reg-macports.org@…

Attachment: Portfile.2 added

new version

Changed 8 years ago by reg-macports.org@…

Attachment: files.zip added

new version

comment:5 Changed 8 years ago by reg-macports.org@…

I've added new versions of Portfile and the files/ directory to go with the new version for p5-eperl in #26534.

comment:6 Changed 8 years ago by neverpanic (Clemens Lang)

Owner: changed from macports-tickets@… to cal@…
Status: newassigned

comment:7 Changed 8 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: assignedclosed

r83533.

I'm not sure I'm supposed to list you as maintainer, but feel free to open a ticket whenever you feel something needs to be changed with the port. You might want to ask on -dev to become maintainer.

Depending on p5-* packages is a bad idea for reasons I have forgotten by now. If you want to support multiple versions of perl, make variants to do so (e.g. the rpm52 port does this to some extent).

I've also increased the revision for wml, so people will see the need to rebuild.

Checksums are sha512 and rmd160 by now, your file only had md5.

comment:8 Changed 8 years ago by mf2k (Frank Schima)

Cc: reg-macports.org@… removed

@cal: Anyone can be added as a maintainer if the port is nomaintainer or openmaintainer. So the reporter can be this port's maintainer.

comment:9 in reply to:  8 Changed 8 years ago by neverpanic (Clemens Lang)

Replying to macsforever2000@…:

@cal: Anyone can be added as a maintainer if the port is nomaintainer or openmaintainer. So the reporter can be this port's maintainer.

Thanks for the info. In this case: r83535, welcome aboard.

comment:10 Changed 8 years ago by hahn.seb@…

Resolution: fixed
Status: closedreopened

I'm still getting an error on Lion, happy to provide any additional information that might be helpful:

make[1]: Entering directory `/opt/local/var/macports/build/_Users_Sebastian_ports_www_wml/wml/work/wml-2.0.11/wml_common'
===> wml_common/bitvector (all)
Checking if your kit is complete...
Looks good
Writing Makefile for Bit::Vector
make[2]: Entering directory `/opt/local/var/macports/build/_Users_Sebastian_ports_www_wml/wml/work/wml-2.0.11/wml_common/bitvector'
/Developer/usr/bin/llvm-gcc-4.2 -c   -pipe -O2 -arch x86_64 -fno-common -DPERL_DARWIN -I/opt/local/include -no-cpp-precomp -fno-strict-aliasing -fstack-protector -I/opt/local/include -O3   -DVERSION=\"6.0\" -DXS_VERSION=\"6.0\"  "-I/opt/local/lib/perl5/5.12.3/darwin-multi-2level/CORE"   BitVector.c
/opt/local/bin/perl /opt/local/lib/perl5/vendor_perl/5.12.3/ExtUtils/xsubpp  -typemap /opt/local/lib/perl5/5.12.3/ExtUtils/typemap -typemap typemap  Vector.xs > Vector.xsc && mv Vector.xsc Vector.c
Running Mkbootstrap for Bit::Vector ()
chmod 644 Vector.bs
cp Vector.bs blib/arch/auto/Bit/Vector/Vector.bs
chmod 644 blib/arch/auto/Bit/Vector/Vector.bs
cp Vector.pm blib/lib/Bit/Vector.pm
/Developer/usr/bin/llvm-gcc-4.2 -c   -pipe -O2 -arch x86_64 -fno-common -DPERL_DARWIN -I/opt/local/include -no-cpp-precomp -fno-strict-aliasing -fstack-protector -I/opt/local/include -O3   -DVERSION=\"6.0\" -DXS_VERSION=\"6.0\"  "-I/opt/local/lib/perl5/5.12.3/darwin-multi-2level/CORE"   Vector.c
In file included from BitVector.h:12,
                 from Vector.xs:19:
ToolBox.h:82: error: expected identifier before numeric constant
make[2]: *** [Vector.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/opt/local/var/macports/build/_Users_Sebastian_ports_www_wml/wml/work/wml-2.0.11/wml_common/bitvector'
make[1]: *** [all] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_Users_Sebastian_ports_www_wml/wml/work/wml-2.0.11/wml_common'
make: *** [all] Error 1
make: Leaving directory `/opt/local/var/macports/build/_Users_Sebastian_ports_www_wml/wml/work/wml-2.0.11'
shell command " cd "/opt/local/var/macports/build/_Users_Sebastian_ports_www_wml/wml/work/wml-2.0.11" && /usr/bin/make -j8 -w all CC=/Developer/usr/bin/llvm-gcc-4.2 CPP=/Developer/usr/bin/llvm-cpp-4.2 " returned error 2
Error: Target org.macports.build returned: shell command failed (see log for details)
DEBUG: Backtrace: shell command failed (see log for details)
    while executing
"command_exec build"
    (procedure "portbuild::build_main" line 8)
    invoked from within
"$procedure $targetname"
Warning: the following items did not execute (for wml): org.macports.activate org.macports.build org.macports.destroot org.macports.install
Error: Status 1 encountered during processing.
To report a bug, see <http://guide.macports.org/#project.tickets>

comment:11 Changed 8 years ago by neverpanic (Clemens Lang)

It seems you're not running the current version of the Portfile. Building bitvector has been patched out (see patch-Makefile.in.diff in files.zip).

Does port info wml show wml @2.0.11, Revision 2 for you?

comment:12 Changed 8 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.