Opened 10 years ago

Closed 10 years ago

#26647 closed update (fixed)

mkvtoolnix-4.3.0 maintainer update

Reported by: ruud@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: maintainer haspatch Cc:
Port: mkvtoolnix

Description (last modified by ryandesign (Ryan Schmidt))

Updated Portfile from 3.2.0 to 4.3.0

There are some additional changes:

  • configure patch removed (not in patch, remove manually)
  • Builds universal now
  • Changed for the packages new build-system (build_deps port:ruby)
  • Added default variants according to default configure output

Attachments (2)

Portfile-4.3.0.diff (1.8 KB) - added by ruud@… 10 years ago.
mkvtoolnix-ryandesign.diff (3.3 KB) - added by ryandesign (Ryan Schmidt) 10 years ago.
proposed patch

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by ruud@…

Attachment: Portfile-4.3.0.diff added

comment:1 Changed 10 years ago by ryandesign (Ryan Schmidt)

Description: modified (diff)
Keywords: maintainer haspatch added

comment:2 Changed 10 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

On Snow Leopard, with the +universal variant, configure says:

configure: WARNING: unrecognized options: --disable-dependency-tracking, --enable-bzip2

According to "./configure --help", "--enable-bzip2" should be "--enable-bz2" so I'll change that.

The universal build says:

g++-4.2: -E, -S, -save-temps and -M options are not allowed with multiple -arch flags

(and stops there) so I won't reenable the universal variant at this time. If you can make the universal variant work, please supply a new patch.

comment:3 Changed 10 years ago by ryandesign (Ryan Schmidt)

According to "otool -L", mkvtoolnix ended up linked with libmagic.1.dylib, which is provided by the file port, though no library dependency on the file port was declared. It also ended up linked with libintl.8.dylib, which is provided by the gettext port, though no library dependency on gettext was declared. And even when I disable the bzip2 and lzo variants, it ends up linked with libbz2.1.0.dylib and liblzo2.2.dylib.

bzip2, lzo and file are not large ports; on my 3-year-old MacBook Pro, bzip2 took 4 seconds to build, lzo took 37 seconds, and file took 30 seconds. even flac only takes 90 seconds to build. These are negligible compared to the 9 minutes mkvtoolnix took to build. So we can dispense with the variants entirely and just declare the dependencies in the main part of the port.

gettext is not small, but is already an indirect dependency through lzo's build dependency on autoconf, and everybody will have gettext installed anyway since so many ports use it.

I'm attaching a revised update proposal; does this look ok to you?

Changed 10 years ago by ryandesign (Ryan Schmidt)

Attachment: mkvtoolnix-ryandesign.diff added

proposed patch

comment:4 in reply to:  3 Changed 10 years ago by ruud@…

Replying to ryandesign@…:

According to "otool -L", mkvtoolnix ended up linked with libmagic.1.dylib, which is provided by the file port, though no library dependency on the file port was declared. It also ended up linked with libintl.8.dylib, which is provided by the gettext port, though no library dependency on gettext was declared. And even when I disable the bzip2 and lzo variants, it ends up linked with libbz2.1.0.dylib and liblzo2.2.dylib.

I'm attaching a revised update proposal; does this look ok to you?

Odd that I didn't notice that before, though nothing is mentioned in the (on-line) dependency list. But your changes look good.

comment:5 Changed 10 years ago by jmroot (Joshua Root)

Reporter: changed from ruud@… to ruud@…

comment:6 Changed 10 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

Updated in r71927. The changes from my patch are the addition of "--with-boost=${prefix}" to fix non-standard MacPorts prefixes (see #23829) and the removal of "destroot.cmd ./drake" since there's already "build.cmd ./drake" and the default for destroot.cmd is the value of build.cmd.

Note: See TracTickets for help on using tickets.