graphics/feh crashes after upgrading to xorg-libX11 @1.3.6_1

[johnrosshunt@…]

feh, an image viewer built on top of imlib2, segfaults after upgrading to xorg-libX11 @1.3.6_1. Downgrading to xorg-libX11 @1.3.5_0 fixes the segfault. I rebuilt my entire MacPorts from scratch in case of an ABI problem, but the crash still occurs with xorg-libX11 @1.3.6_1.

[johnrosshunt@…]

Crash report

[johnrosshunt@…]

System specs: Mac OS X Version 10.6.4

uname -a: Darwin MacBook.local 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386 i386 MacBook5,2 Darwin

MacPorts 1.9.1

[jmroot (Joshua Root)]

Please remember to fill in the Port field and cc the maintainer.

The crash log shows that feh is linked against libs in both /usr/X11/lib and /opt/local/lib, which is probably the problem.

[jeremyhu (Jeremy Huddleston Sequoia)]

feh and giblib upstream fail. They need to fix their packages:

1) They are shipping configure.in and configure.ac

2) They are setting CFLAGS and LDFLAGS directly in configure.ac

3) They are setting CFLAGS and LDFLAGS directly in Makefile.am

4) They are assuming that X11 is in /usr/X11R6 rather than using PKG_CONFIG to find the info

[jeremyhu (Jeremy Huddleston Sequoia)]

Here is a dirty patch we can use until upstream gets their act together:

Index: Portfile
===================================================================
--- Portfile	(revision 71711)
+++ Portfile	(working copy)
@@ -3,7 +3,7 @@
 PortSystem			1.0
 name				feh
 version				1.3.4
-revision            2
+revision			3
 categories			graphics
 maintainers			cs.dartmouth.edu:tristan
 description			Fast lightweight image viewer
@@ -20,7 +20,15 @@
 
 depends_lib			port:giblib port:imlib2 port:jpeg port:libpng port:zlib
 
-configure.args		--mandir=${prefix}/share/man
+use_autoreconf yes
+autoreconf.args -fvi
 
+patch {
+	reinplace "s:/usr/X11R6:${prefix}:g" ${worksrcpath}/configure.ac
+	reinplace "s:/usr/X11R6:${prefix}:g" ${worksrcpath}/configure.in
+	reinplace "s:/usr/X11R6:${prefix}:g" ${worksrcpath}/Makefile.am
+	reinplace "s:/usr/X11R6:${prefix}:g" ${worksrcpath}/src/Makefile.am
+}
+
 destroot.args		docsdir=${prefix}/share/doc/${name}

[mbroemme@…]

I think the 1.3.4 version of 'feh' will never be fixed in upstream. Its development was stopped with last public release 1.3.4. The reincarnation of 'feh' is at version 1.9 and has a new maintainer.

​https://derf.homelinux.org/projects/feh/

This version no longer uses autoconf and automake, so either upgrade either 'feh' or maintain the patch from macports.

[jeremyhu (Jeremy Huddleston Sequoia)]

r72025