Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#26725 closed update (fixed)

UPDATE: sbt @0.7.4 to correct reported launcher script problems

Reported by: lists@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.9.1
Keywords: Cc:
Port: sbt

Description

I have attached patches to both the launcher script and the Portfile. The Portfile patch only increments the revision value.

--- /opt/local/var/macports/sources/rsync.macports.org/release/ports/devel/sbt/Portfile	2010-07-13 20:00:52.000000000 -0400
+++ ./Portfile	2010-10-03 08:27:59.000000000 -0400
@@ -5,6 +5,7 @@
 
 name                sbt
 version             0.7.4
+revision            1
 categories          devel java
 maintainers         jon.buffington.name:me
 platforms           darwin
--- /opt/local/var/macports/sources/rsync.macports.org/release/ports/devel/sbt/files/sbt.sh	2010-07-13 20:00:52.000000000 -0400
+++ ./files/sbt.sh	2010-10-03 08:39:22.000000000 -0400
@@ -1,6 +1,6 @@
 #!/bin/sh
 #
-# Copyright (c) 2007-2009 Jon Buffington. All rights reserved.
+# Copyright (c) 2010 Jon Buffington. All rights reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -17,17 +17,10 @@
 # Is the location of the SBT launcher JAR file.
 LAUNCHJAR="__SBT_LAUNCHER_PATH__"
 
-# Capture any arguments
-QUOTED_ARGS=""
-while [ "$1" != "" ] ; do
-	QUOTED_ARGS="$QUOTED_ARGS \"$1\""
-	shift
-done
-
 # Ensure enough heap space is created for SBT.
 if [ -z "$JAVA_OPTS" ]; then
 	JAVA_OPTS="-Xmx512M"
 fi
 
 # Assume java is already in the shell path.
-exec java $JAVA_OPTS -jar "$LAUNCHJAR" $QUOTED_ARGS
+exec java $JAVA_OPTS -jar "$LAUNCHJAR" "$@"

Attachments (2)

Portfile.patch (372 bytes) - added by lists@… 10 years ago.
sbt.sh.patch (950 bytes) - added by lists@… 10 years ago.

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by lists@…

Attachment: Portfile.patch added

Changed 10 years ago by lists@…

Attachment: sbt.sh.patch added

comment:1 Changed 10 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Port: sbt added
Status: newassigned

comment:2 Changed 10 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

I committed your patch in r72141, and I also added the line "extract.only" to avoid the error message "gzip: /opt/local/var/macports/distfiles/sbt/sbt-launch-0.7.4.jar has more than one entry--rest ignored" during the extract phase.

comment:3 in reply to:  2 Changed 10 years ago by lists@…

Replying to ryandesign@…:

I committed your patch in r72141, and I also added the line "extract.only" to avoid the error message "gzip: /opt/local/var/macports/distfiles/sbt/sbt-launch-0.7.4.jar has more than one entry--rest ignored" during the extract phase.

Thanks for the improvement and committing the update.

Note: See TracTickets for help on using tickets.