Opened 13 years ago

Closed 12 years ago

#26815 closed enhancement (fixed)

mkvtoolnix builds with ruby19

Reported by: dmitry.gladkov@… Owned by: kona8lend@…
Priority: Normal Milestone:
Component: ports Version: 1.9.1
Keywords: Cc: ruud@…, ryandesign (Ryan Carsten Schmidt)
Port: mkvtoolnix

Description

mkvtoolnix successfully builds and works with 'ruby19' installed, not just 'ruby' package. There is should be an option to build mkvtoolnix with ruby19

P.S. I have symlinks from ruby19, irb19, erb19 and so on to ruby, irb, erb. Maybe it won't build otherwise

Attachments (1)

mkvtoolnix-nukeruby.diff (557 bytes) - added by Kona8lend@… 12 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 13 years ago by ruud@…

As far as I know the build system doesn't care what version of ruby you have, and neither do I. I just picked the most obvious port for the Portfile. If a dev knows an easy way to support both I'm all for it.

comment:2 Changed 13 years ago by rmstonecipher@…

Dmitry, I do not have any ruby other than 'ruby' installed, but perhaps the following substitution would resolve this issue:

-depends_build       port:ruby
+depends_build       path:lib/libruby.dylib:ruby

This would depend, of course, on your specific ruby providing ${prefix}/lib/libruby.dylib.
If it works and Ruud (let me know if that's your surname and I'll be sure to address you as Mr. Ruud) approves, I can commit this change.

Cheers,
Ryan

comment:3 in reply to:  2 Changed 13 years ago by ruud@…

Replying to rmstonecipher@…:

Dmitry, I do not have any ruby other than 'ruby' installed, but perhaps the following substitution would resolve this issue:

-depends_build       port:ruby
+depends_build       path:lib/libruby.dylib:ruby

This would depend, of course, on your specific ruby providing ${prefix}/lib/libruby.dylib.
If it works and Ruud (let me know if that's your surname and I'll be sure to address you as Mr. Ruud) approves, I can commit this change.

Cheers,
Ryan

I thought that was changed last time. Anyway, fine with me. Ow, and Ruud is my first name; no mr required.

comment:4 Changed 13 years ago by rmstonecipher@…

Ruud,
It looks like Dmitry was right; not a single file is provided by both ruby19 and ruby.
My idea for setting the dependency using path:path/to/file:port will not work.

Ryan Stonecipher

comment:5 Changed 13 years ago by jmroot (Joshua Root)

Keywords: mkvtoolnix ruby removed
Owner: changed from macports-tickets@… to kona8lend@…

Changed 12 years ago by Kona8lend@…

Attachment: mkvtoolnix-nukeruby.diff added

comment:6 Changed 12 years ago by Kona8lend@…

Here's the state as near as I can figure it:

  1. mkvtoolnix bundles drake which in turn has a build-time dependency on a ruby of version approximately 1.8.x .
  2. build-time dependency is for executable 'ruby' to be found in the path.
  3. MacOSX bundles /usr/bin/ruby thus mkvtoolnix builds without port:ruby and without port:ruby19
  4. drake does not reference or try to use 'ruby1.9' from the path

ruby is bundled on both pertinent versions of MacOSX (10.7 and 10.6) thus build-time dependency for port:ruby or port:ruby19 +nosuffix is not required.

I recommend at this time to remove the build-time dependency for port:ruby. This solves (presumably) the ticket issue of not installing port:ruby unnecessarily.

(see mkvtoolnix-nukeruby.diff above)

comment:7 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

The versions of /usr/bin/ruby supplied by Tiger, Leopard, Snow Leopard and Lion are all compatible with drake?

comment:8 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Type: defectenhancement

comment:9 Changed 12 years ago by Kona8lend@…

Why was port:ruby added as a dependency in r71927 ? Let's just delete this dependency and if Tiger's ruby-1.8.2 is insufficient, a conditional dependency for 10.4 can easily be added.

comment:10 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.