Opened 11 years ago

Closed 7 years ago

#26818 closed submission (fixed)

New Port: git-flow-bash-completion

Reported by: gorticus (Jason Mitchell) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: neverpanic (Clemens Lang)
Port: git-flow-bash-completion

Description

Bash (and Zsh) completion support for git-flow

The contained completion routines provide support for completing:

  • git-flow init, feature, hotfix and release
  • feature, hotfix and release branches
  • remote feature branch names (for git-flow feature track)

Project homepage: http://github.com/bobthecow/git-flow-completion

NOTES:

  • For use with git-flow; see New Port ticket #26803.
  • provides bash completion only, no zsh
  • expects git >= 1.7.1 to avoid hand editing /path/to/bash_completion.d/git

Attachments (3)

Portfile (1.4 KB) - added by gorticus (Jason Mitchell) 11 years ago.
Portfile.2 (1023 bytes) - added by robsonpeixoto@… 9 years ago.
Version 0.4.2 using PortGroup github
Portfile.3 (1.3 KB) - added by gorticus (Jason Mitchell) 9 years ago.
few suggestions on Portfile.2

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by gorticus (Jason Mitchell)

Attachment: Portfile added

comment:1 Changed 10 years ago by raimue (Rainer Müller)

In my opinion this should be added as a +bash_completion variant in git-flow.

comment:2 Changed 10 years ago by gorticus (Jason Mitchell)

I agree, but since I'm a n00b, it's a separate pkg, and I wasn't sure how the variants interacted w/ 'fetch.type git', I left it separate.

If you can point me to a dual git pull example, I'll give it a shot.

comment:3 Changed 9 years ago by robsonpeixoto@…

But the git-flow-completion has your own lifecycle.

I'm attaching a version using PortGroup github

Changed 9 years ago by robsonpeixoto@…

Attachment: Portfile.2 added

Version 0.4.2 using PortGroup github

comment:4 in reply to:  3 Changed 9 years ago by gorticus (Jason Mitchell)

Replying to robsonpeixoto@…:

But the git-flow-completion has your own lifecycle.

I'm attaching a version using PortGroup github

Nice. Much more concise.

While I'm no expert, I have a few suggestions/questions, based on port lint:

  • name needs to be set to git-flow-bash-completion indicate bash only
  • the distribution license is MIT as indicated on the homepage
  • category is not set by portgroup
  • does copy ensure the correct permissions? (Tcl is a 4th+ language for me)
  • add openmaintainer
  • # $Id$ is required
  • platforms is required (darwin)

Suggestions are included in Portfile.3 attached.

Changed 9 years ago by gorticus (Jason Mitchell)

Attachment: Portfile.3 added

few suggestions on Portfile.2

comment:5 in reply to:  3 Changed 9 years ago by gorticus (Jason Mitchell)

Replying to robsonpeixoto@…:

But the git-flow-completion has your own lifecycle.

I'm attaching a version using PortGroup github

I should probably update git-flow based on your portgroup changes. I checked ffmpeg and it should be straightforward to make this an option for git-flow, but as you correctly noted, would require separate updates since the lifecycle is separate, but related.

comment:6 Changed 7 years ago by neverpanic (Clemens Lang)

Cc: cal@… added
Resolution: fixed
Status: newclosed

I agree this would better be integrated into the git-flow ports, but now that there are a lot of them and given the separate lifecycles I'm not exactly sure how I'd achieve that either. I'm committing as-is to avoid leaving this laying around for an even longer time. r122829.

Note: See TracTickets for help on using tickets.