Opened 13 years ago

Closed 13 years ago

Last modified 10 years ago

#26992 closed enhancement (fixed)

qscintilla : enable universal variant

Reported by: petr@… Owned by: adfernandes (Andrew Fernandes)
Priority: Normal Milestone:
Component: ports Version: 1.9.1
Keywords: Cc: cooljeanius (Eric Gallager)
Port: qscintilla

Description

currently building qscintilla with "universal" variant is not available. Port contains "universal_variant no"

But anyway I'm able to build it as an universal lib with simple patch file

--- Portfile.local      2010-10-25 11:57:51.000000000 +0200
+++ Portfile    2010-10-25 11:42:20.000000000 +0200
@@ -39,7 +39,8 @@
                     sha1    2401c2214ba0377ad61855c0fac6f6c7c95801d6 \
                     rmd160  d96cf05c879f314ee828ec6a1609bd1864692bd6
 
-universal_variant   no
+universal_variant   yes
+patchfiles          patch-Qt4-qscintilla.pro.diff
 
 post-patch {
     # fix up 'Platform.h's, to avoid a conflict with the port 'tidy's

and the patch-Qt4-qscintilla.pro.diff contains only this change:

Index: Qt4/qscintilla.pro
===========================================================
--- Qt4/qscintilla.pro  2010-10-15 11:15:11.000000000 +0200
+++ Qt4/qscintilla.pro  2010-10-15 11:16:20.000000000 +0200
@@ -34,6 +34,7 @@
 TEMPLATE = lib
 TARGET = qscintilla2
 CONFIG += qt warn_off release dll thread
+CONFIG += x86 x86_64
 INCLUDEPATH = . ../include ../src
 DEFINES = QSCINTILLA_MAKE_DLL QT SCI_LEXER

well, I don't know if it can be done in some abstract way - to use architectures specified in macports universal config for that patch file... Please, take it as a proof of concept (working in real life applications ;))

Change History (3)

comment:1 Changed 13 years ago by jmroot (Joshua Root)

Owner: changed from macports-tickets@… to adfernandes@…
Type: defectenhancement

Please remember to cc the maintainer.

comment:2 Changed 13 years ago by adfernandes (Andrew Fernandes)

Resolution: fixed
Status: newclosed

Fixed in r72741.

comment:3 Changed 10 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

Note: See TracTickets for help on using tickets.