Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#27479 closed defect (fixed)

mozplugger builds universal even when the universal variant was not requested

Reported by: ryandesign (Ryan Schmidt) Owned by: jeremyhu (Jeremy Huddleston Sequoia)
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc:
Port: mozplugger

Description

$ sudo port install mozplugger -universal
Password:
--->  Fetching mozplugger
--->  Attempting to fetch mozplugger-1.14.2.tar.gz from http://distfiles.macports.org/mozplugger
--->  Verifying checksum(s) for mozplugger
--->  Extracting mozplugger
--->  Configuring mozplugger
--->  Building mozplugger
--->  Staging mozplugger into destroot
--->  Installing mozplugger @1.14.2_0
--->  Activating mozplugger @1.14.2_0
--->  Cleaning mozplugger
$ port -v installed mozplugger
The following ports are currently installed:
  mozplugger @1.14.2_0 (active) platform='darwin 10' archs='x86_64'
$ port -q contents mozplugger | grep /bin/ | xargs lipo -info
Architectures in the fat file: /opt/local/bin/mozplugger-controller are: x86_64 i386 
Architectures in the fat file: /opt/local/bin/mozplugger-helper are: x86_64 i386 
Architectures in the fat file: /opt/local/bin/mozplugger-linker are: x86_64 i386 
$ 

r73886 caused this, because it unconditionally uses ${configure.universal_whatever}. These should only be used if the universal variant is selected. And their non-universal counterparts should be used in the other case, to support changing the build_arch.

Attachments (1)

mozplugger-universal.diff (218 bytes) - added by ryandesign (Ryan Schmidt) 7 years ago.
proposed patch

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by jeremyhu (Jeremy Huddleston Sequoia)

  • Resolution set to fixed
  • Status changed from new to closed

I thought those were only set if we were +universal...

r73898

comment:2 Changed 7 years ago by ryandesign (Ryan Schmidt)

  • Resolution fixed deleted
  • Status changed from closed to reopened

They're always set.

You also need to actually create a universal variant, as in the attached patch.

Changed 7 years ago by ryandesign (Ryan Schmidt)

proposed patch

comment:3 Changed 7 years ago by ryandesign (Ryan Schmidt)

  • Resolution set to fixed
  • Status changed from reopened to closed

Ah, it's openmaintainer; I fixed it in r73905.

comment:4 in reply to: ↑ description Changed 7 years ago by ryandesign (Ryan Schmidt)

Replying to ryandesign@…:

And their non-universal counterparts should be used in the other case, to support changing the build_arch.

Fixed this in r73906.

Note: See TracTickets for help on using tickets.