Opened 13 years ago
Closed 13 years ago
#27652 closed defect (fixed)
php5, php5-devel missing suhosin patch
| Reported by: | davidfavor (David Favor) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.9.2 |
| Keywords: | suhosin | Cc: | Markus.Ueberall@… |
| Port: | php5, php5-devel |
Description
This has been broken for several days now. No bug reported. No fix submitted.
Fetches for suhosin-patch-5.3.4-0.9.10.patch.gz fail for all source entries in the list.
Most likely the maintainer missed uploading this patch with the port file.
Attachments (1)
Change History (5)
comment:1 follow-up: 3 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Keywords: | php5 patch removed |
|---|---|
| Owner: | changed from macports-tickets@… to ryandesign@… |
| Port: | php5-devel added |
| Priority: | High → Normal |
| Status: | new → assigned |
| Summary: | php-5.3.4 broken, missing suhosin-patch-5.3.4-0.9.10.patch.gz → php5, php5-devel missing suhosin-patch-5.3.4-0.9.10.patch.gz |
comment:2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Summary: | php5, php5-devel missing suhosin-patch-5.3.4-0.9.10.patch.gz → php5, php5-devel missing suhosin patch |
|---|
Added explanation to the ports in r74326.
comment:3 follow-up: 4 Changed 13 years ago by Markus.Ueberall@…
Replying to ryandesign@…:
Once they release a version of their patch that works with 5.3.4, I will be happy to update the port.
Luckily, an updated version of the patch is available since last year ;)
Since to my knowledge, there is not a single Linux, *BSD distribution which doesn't include the patch per default, may I suggest that future versions of the php5* ports follow suit and include a default_variant definition? (I added one in the attached patch php5-Portfile.diff.)
OTOH, it could be argued that it's better to wait for 5.3.5/5.4 until the default is changed--in that case, "revision" doesn't necessarily need to be bumped.
Changed 13 years ago by Markus.Ueberall@…
| Attachment: | php5-Portfile.diff added |
|---|
Portfile diff (updated suhosin patch checksums, added default_port definition, bumped revision)
comment:4 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | Markus.Ueberall@… added |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Replying to Markus.Ueberall@…:
Replying to ryandesign@…:
Once they release a version of their patch that works with 5.3.4, I will be happy to update the port.
Luckily, an updated version of the patch is available since last year ;)
Thanks for letting me know. I updated php5 and php5-devel with this information in r74780.
Since to my knowledge, there is not a single Linux, *BSD distribution which doesn't include the patch per default, may I suggest that future versions of the php5* ports follow suit and include a
default_variantdefinition? (I added one in the attached patchphp5-Portfile.diff.)
OTOH, it could be argued that it's better to wait for 5.3.5/5.4 until the default is changed--in that case, "revision" doesn't necessarily need to be bumped.
I was not aware that other distributions are including the suhosin patch by default. I am not really comfortable doing that; I would think that if the suhosin patch were suitable for general inclusion in php, the developers of php would have already done so. If you'd like to see the suhosin patch included in php, you should speak with the developers of php about that. If you'd like to further discuss the idea of making the suhosin variant the default, that should probably happen in another ticket or on the macports-users mailing list, since this ticket, which is about the absence of the suhosin patch for php 5.3.4, has now been resolved.
No 5.3.4 version of the suhosin patch exists. Direct complaints about this to the suhosin people. Once they release a version of their patch that works with 5.3.4, I will be happy to update the port.