Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#27672 closed defect (fixed)

gdal +universal fails to patch cpl_config.h on 32-bit systems

Reported by: pt.responder@… Owned by: seanasy@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc: mf2k (Frank Schima)
Port: gdal

Description (last modified by ryandesign (Ryan Schmidt))

patching file port/cpl_config.h
Hunk #1 FAILED at 143.
1 out of 1 hunk FAILED -- saving rejects to file port/cpl_config.h.rej
shell command "cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gis_gdal/work/gdal-1.7.3 && patch -p0 < /opt/local/var/macports/sources/rsync.macports.org/release/ports/gis/gdal/files/patch_cpl_config_h" returned error 1

Attachments (1)

main.log.bz2 (4.0 KB) - added by pt.responder@… 10 years ago.
main.log of build process

Download all attachments as: .zip

Change History (11)

comment:1 Changed 10 years ago by Veence (Vincent)

I cannot reproduce this

-> port -v build gdal
--->  Computing dependencies for gdal.
--->  Fetching gdal
--->  Verifying checksum(s) for gdal
--->  Checksumming gdal-1.7.3.tar.gz
--->  Extracting gdal
--->  Extracting gdal-1.7.3.tar.gz

[…]

  Statically link PROJ.4:    yes
  enable OGR building:       yes
  enable pthread support:    no
  hide internal symbols:     no

patching file port/cpl_config.h
--->  Building gdal

Changed 10 years ago by pt.responder@…

Attachment: main.log.bz2 added

main.log of build process

comment:2 Changed 10 years ago by pt.responder@…

build on 32 bit intel using ccache using gcc 4.0

comment:3 Changed 10 years ago by Veence (Vincent)

I'll test that on an old Mac Mini tomorrow and see if I get the same error.

comment:4 Changed 10 years ago by ryandesign (Ryan Schmidt)

Description: modified (diff)
Keywords: gdal patch clp_config.h removed
Owner: changed from macports-tickets@… to seanasy@…
Port: gdal added

comment:5 Changed 10 years ago by ryandesign (Ryan Schmidt)

Cc: macsforever2000@… added

The problem only occurs when using the universal variant, on a computer where configure does not determine that SIZEOF_UNSIGNED_LONG and SIZEOF_VOIDP are both 8 -- in other words, on 32-bit machines like PowerPC G4 (not G5) and Intel Core (not Core 2) processors.

The whole point of the configure script is to discover values like this that differ by machine, so it doesn't make sense to then try to apply a patch on top of that; it can't help but fail in some cases. This is why we do this kind of after-the-fact changing of the values the configure script found by using an ed script, not a patch. See glib2, neon, lzo, etc. for examples.

The problem changes were made to the port in r46597.

comment:6 Changed 10 years ago by ryandesign (Ryan Schmidt)

Summary: gdal @1.7.3 + patch error on file cpl_config.h -build failuregdal +universal fails to patch cpl_config.h on 32-bit systems

comment:7 Changed 10 years ago by ryandesign (Ryan Schmidt)

Issue confirmed on my Power Mac G4 with Leopard.

comment:8 Changed 10 years ago by Veence (Vincent)

I have updated the build system to adopt the 'ed' file paradigm. Please update and try again.

comment:9 Changed 10 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed

Thanks, confirmed that r74405 + r74406 do fix this.

comment:10 Changed 10 years ago by pt.responder@…

Confirmed fixed many thanks. Paula

Note: See TracTickets for help on using tickets.