Opened 13 years ago

Closed 13 years ago

#27760 closed update (fixed)

dbus: update to 1.4.1

Reported by: henning@… Owned by: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc: ryandesign (Ryan Carsten Schmidt), mkae (Marko Käning), drkp (Dan Ports)
Port: dbus

Description (last modified by ryandesign (Ryan Carsten Schmidt))

os x 10.6.5, x11 2.4.0

after following the "How to upgrade a port's version locally" instructions i failed to

% sudo port -d install dbus      (logfile attached).

carrying out

% port clean --all

and

% port clean openssl

did not change it.

trying to

% port uninstall dbus

and

% port -nR upgrade --force dbus

also failed (log attached).

please help! thanks!

Attachments (6)

port -d install dbus.log (18.3 KB) - added by henning@… 13 years ago.
port -nR upgrade --force dbus.log (2.7 KB) - added by henning@… 13 years ago.
main.log (22.0 KB) - added by henning@… 13 years ago.
dbus_1.4.8.patch (36.8 KB) - added by mtalexander (Mike Alexander) 13 years ago.
Update dbus to version 1.4.8
dbus_1.4.10.2.patch (36.8 KB) - added by mtalexander (Mike Alexander) 13 years ago.
Upgrade dbus to version 1.4.10
dbus_1.4.10.patch (36.8 KB) - added by mtalexander (Mike Alexander) 13 years ago.
Upgrade dbus to version 1.4.10

Download all attachments as: .zip

Change History (17)

Changed 13 years ago by henning@…

Attachment: port -d install dbus.log added

Changed 13 years ago by henning@…

comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added
Description: modified (diff)
Keywords: Reversed (or previously applied) patch detected! removed
Owner: changed from macports-tickets@… to mcalhoun@…
Port: 1.4.1 removed

Both logs show the patch phase of dbus failing to apply a patch, probably because it was already applied the last time you tried to install dbus. Clean dbus ("sudo port clean dbus") and try again.

comment:2 in reply to:  1 Changed 13 years ago by henning@…

Replying to ryandesign@…:

Both logs show the patch phase of dbus failing to apply a patch, probably because it was already applied the last time you tried to install dbus. Clean dbus ("sudo port clean dbus") and try again.

thanks for the fast reply!

i just tried it and did not succeed. failure output in the terminal:

Error: Target org.macports.patch returned: shell command failed (see log for details)
Log for dbus is at: /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_devel_dbus/main.log
Error: Status 1 encountered during processing.
To report a bug, see <http://guide.macports.org/#project.tickets>
Henning-Richters-MacBook-Pro:~ henningrichter$ 

any further advice?

should i reinstall all of macports? if yes- how?

thanks

comment:3 Changed 13 years ago by henning@…

... or could dbus version 1.4.1 be the cause? the patches seem to have been written for version 1.4.0...

comment:4 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Please attach the new main.log file that you got.

Changed 13 years ago by henning@…

Attachment: main.log added

comment:5 Changed 13 years ago by henning@…

sure! here it comes...

comment:6 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Summary: dbus 1.4.1 port update fails on mac os 10.6.5dbus: update to 1.4.1

Ok, so the real error is:

:debug:patch Assembled command: 'cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_devel_dbus/work/dbus-1.4.1" && /usr/bin/patch -p1'
:info:patch The next patch would create the file dbus/dbus-server-launchd.c,
:info:patch which already exists!  Assume -R? [n] 
:info:patch Apply anyway? [n] 
:info:patch Skipping patch.
:info:patch 1 out of 1 hunk ignored -- saving rejects to file dbus/dbus-server-launchd.c.rej
:info:patch The next patch would create the file dbus/dbus-server-launchd.h,
:info:patch which already exists!  Assume -R? [n] 
:info:patch Apply anyway? [n] 
:info:patch Skipping patch.
:info:patch 1 out of 1 hunk ignored -- saving rejects to file dbus/dbus-server-launchd.h.rej
:info:patch patching file dbus/dbus-sysdeps-unix.c
:info:patch Hunk #1 succeeded at 3425 with fuzz 1 (offset 111 lines).
:info:patch Hunk #2 FAILED at 3544.
:info:patch 1 out of 2 hunks FAILED -- saving rejects to file dbus/dbus-sysdeps-unix.c.rej

So, the patchfiles in the port are designed for the current version of the port -- 1.2.24. You've presumably updated the portfile to version 1.4.1, but haven't updated the patches, or haven't updated them completely. Part of the task of updating a port is to deal with updating the patches, determining which ones need to be updated, which ones can be deleted, and what new patches might be needed.

It sounds like we can boil this ticket down to the request to update dbus to 1.4.1, so let's just make it that, and let the maintainer of the port deal with doing that update. Unless you figure it out sooner, in which case, by all means attach a patch to this ticket.

comment:7 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Type: defectupdate

comment:8 Changed 13 years ago by henning@…

i see... now since i'm not a developer there's no way i could write any code for a patch - so i'll leave it to the maintainer. thanks anyway.

comment:9 Changed 13 years ago by mkae (Marko Käning)

Cc: mk@… added

Cc Me!

comment:10 Changed 13 years ago by drkp (Dan Ports)

Cc: dports@… added

dbus 1.4.1 appears to have launchd support integrated, so perhaps some or all of the patches aren't necessary anymore?

Changed 13 years ago by mtalexander (Mike Alexander)

Attachment: dbus_1.4.8.patch added

Update dbus to version 1.4.8

comment:11 Changed 13 years ago by mtalexander (Mike Alexander)

I've attached a patch that updates the dbus port to version 1.4.8. Most of this patch simply deletes the first four patch files since they have been included upstream. The patch simply removes the contents of the four files, leaving empty files behind. Whomever applies this should delete the files entirely.

Changed 13 years ago by mtalexander (Mike Alexander)

Attachment: dbus_1.4.10.patch added

Upgrade dbus to version 1.4.10

comment:12 Changed 13 years ago by pixilla (Bradley Giesbrecht)

Resolution: fixed
Status: newclosed

Updated r79191.

Note: See TracTickets for help on using tickets.