Opened 10 years ago

Last modified 19 months ago

#27826 new enhancement

py-pyqt4: switch from mac to x11 dist for dbus support

Reported by: okmacports@… Owned by: michaelld (Michael Dickens)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: nerdling (Jeremy Lavergne), petrrr, chrstphrchvz (Christopher Chavez)
Port: py-pyqt4

Description

I have ported the HPLIP software successfully and have been working on the GUI variant, which requires a Python module: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=520789

Specifically, the GUI app fails on this statement:

  from dbus.mainloop.qt import DBusQtMainLoop

this is the "dbus support module" in PyQt4, which is offered only for the X11 (not the mac) variant.

I went to the site that hosts the source code, which has been updated to version 4.8.2, which in turn requires the latest version of SIP. Both built with no problem with only minor changes in the Portfiles. (SIP only needed to change the version number and checksums.)

I have attached a diff for the working new Portfile for py26-pyqt4 enabling dbus support.

Attachments (3)

Portfile.diff (1.5 KB) - added by okmacports@… 10 years ago.
Portfile diff for py26-pyqt4
Portfile.2.diff (874 bytes) - added by okmacports@… 10 years ago.
Portfile diff for py26-sip
Portfile.3.diff (1.4 KB) - added by okmacports@… 10 years ago.
diff against 4.8.2 Portfile

Download all attachments as: .zip

Change History (15)

Changed 10 years ago by okmacports@…

Attachment: Portfile.diff added

Portfile diff for py26-pyqt4

Changed 10 years ago by okmacports@…

Attachment: Portfile.2.diff added

Portfile diff for py26-sip

comment:1 Changed 10 years ago by jmroot (Joshua Root)

Resolution: invalid
Status: newclosed

These were both updated 5 days ago.

comment:2 Changed 10 years ago by okmacports@…

Resolution: invalid
Status: closedreopened

Attaching a new Portfile.diff (against the current @4.8.2) to address the dbus issue.

Changed 10 years ago by okmacports@…

Attachment: Portfile.3.diff added

diff against 4.8.2 Portfile

comment:3 Changed 10 years ago by ryandesign (Ryan Schmidt)

You most likely shouldn't just change the distname and the checksums if you're not also going to update the version or revision as well. Doesn't changing the distname change what files get installed?

Does this issue affect py-pyqt4, py25-pyqt4, py27-pyqt4 and py31-pyqt4 as well?

comment:4 in reply to:  3 Changed 10 years ago by okmacports@…

Replying to ryandesign@…:

You most likely shouldn't just change the distname and the checksums if you're not also going to update the version or revision as well. Doesn't changing the distname change what files get installed?

Does this issue affect py-pyqt4, py25-pyqt4, py27-pyqt4 and py31-pyqt4 as well?

As I read the documentation on the "revision" keyword it should be used only if everyone who has an existing install should upgrade. I'll leave that decision to people with more authority than me. Can't change the version because that depends on the source version.

It surely does affect all those other ports, for people who would want dbus support. For me, that affects only HPLIP, which uses py26.

I don't know if this will build without having the dbus port installed. It seems to me that most people would not want to install dbus, so perhaps the best approach would be to make this a variant (like +gui, perhaps call it +dbus). In any case, the sole difference between the existing py26-pyqt4 and the proposed new version is that it is built from the x11 tree rather than the mac tree at the source. (The mac tree does not have the dbus module; the x11 tree does.) All the patches remain the same.

Thanks for taking a look.

comment:5 Changed 10 years ago by nerdling (Jeremy Lavergne)

Cc: snc@… added
Summary: py26-pyqt4 @4.8.1 lacks dbus support and has been updated upstreampy26-pyqt4 switch from mac to x11 dist for dbus support

It sounds like we should create a py26-pyqt4-x11 and rename the existing one to py26-pyqt4-mac.

comment:6 in reply to:  5 Changed 10 years ago by okmacports@…

Replying to snc@…:

It sounds like we should create a py26-pyqt4-x11 and rename the existing one to py26-pyqt4-mac.

That's fine to me, but then what about all the other versions? (py25, py31, etc.) In any event, since the only difference is dbus support, perhaps py26-pyqt4 for the one and py26-pyqt4-dbus for the other (which is why I suggested the +dbus variant -- just one package, with the existing name, where you could turn dbus on or off depending on the variant).

comment:7 Changed 9 years ago by jmroot (Joshua Root)

Cc: michaelld@… removed
Keywords: haspatch added
Owner: changed from macports-tickets@… to michaelld@…
Status: reopenednew
Type: updateenhancement
Version: 1.9.2

comment:8 Changed 9 years ago by michaelld (Michael Dickens)

If this ticket is still valid, can you do the following:

sudo port clean py26-pyqt4
sudo port selfupdate

and then try to install or upgrade py26-pyqt4 again. There's a new qt4-mac and py26-pyqt4 that might fix this issue.

comment:9 Changed 6 years ago by jmroot (Joshua Root)

Port: py-pyqt4 added; py26-pyqt4 removed
Summary: py26-pyqt4 switch from mac to x11 dist for dbus supportpy-pyqt4: switch from mac to x11 dist for dbus support

py26-pyqt4 is no more; newer versions remain. Looks like this is probably either already fixed (in a different way) or heading for a wontfix resolution though.

comment:10 Changed 5 years ago by petrrr

Cc: petr@… added

Cc Me!

comment:11 Changed 19 months ago by chrstphrchvz (Christopher Chavez)

I think this ticket can be closed. qt4-x11 was recently removed ([4a4c1313f8/macports-ports]), which I would think would have been required for this change.

comment:12 Changed 19 months ago by chrstphrchvz (Christopher Chavez)

Cc: chrstphrchvz added
Note: See TracTickets for help on using tickets.