Opened 10 years ago

Closed 10 years ago

#27908 closed update (fixed)

update ccpnmr to 2.1.5

Reported by: howarth@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc:
Port: ccpnmr

Description

Update the ccpnmr package to the latest 2.1.5 release from upstream. Only the version and checksum changes were required.

Attachments (1)

Portfile.diff (1.8 KB) - added by howarth@… 10 years ago.
corrected Portfile diff for ccpnmr 2.1.5

Download all attachments as: .zip

Change History (12)

comment:1 Changed 10 years ago by jmroot (Joshua Root)

Keywords: haspatch maintainer added; science removed
Version: 1.9.2

comment:2 Changed 10 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Thanks.

comment:3 Changed 10 years ago by ryandesign (Ryan Schmidt)

According to the MacPorts base patch from #15514, some of the reinplaces in the port aren't doing anything:

Warning: reinplace s|@PYTHON_LIB@|/opt/local/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6|g didn't change anything in /opt/local/var/macports/build/_Users_rschmidt_macports_dports_science_ccpnmr/work/ccpnmr/ccpnmr2.1/c/environment-opengl.txt
Warning: reinplace s|malloc.h|sys/malloc.h|g didn't change anything in /opt/local/var/macports/build/_Users_rschmidt_macports_dports_science_ccpnmr/work/ccpnmr/ccpnmr2.1/c/memops/global/macros.h

Should I remove them?

comment:4 in reply to:  3 ; Changed 10 years ago by howarth@…

Replying to ryandesign@…:

According to the MacPorts base patch from #15514, some of the reinplaces in the port aren't doing anything:

Warning: reinplace s|@PYTHON_LIB@|/opt/local/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6|g didn't change anything in /opt/local/var/macports/build/_Users_rschmidt_macports_dports_science_ccpnmr/work/ccpnmr/ccpnmr2.1/c/environment-opengl.txt
Warning: reinplace s|malloc.h|sys/malloc.h|g didn't change anything in /opt/local/var/macports/build/_Users_rschmidt_macports_dports_science_ccpnmr/work/ccpnmr/ccpnmr2.1/c/memops/global/macros.h

Should I remove them?

Yes. Those can be removed for ccpnmr 2.1.5.

comment:5 in reply to:  4 Changed 10 years ago by howarth@…

Replying to howarth@…:

Replying to ryandesign@…:

According to the MacPorts base patch from #15514, some of the reinplaces in the port aren't doing anything:

Warning: reinplace s|@PYTHON_LIB@|/opt/local/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6|g didn't change anything in /opt/local/var/macports/build/_Users_rschmidt_macports_dports_science_ccpnmr/work/ccpnmr/ccpnmr2.1/c/environment-opengl.txt
Warning: reinplace s|malloc.h|sys/malloc.h|g didn't change anything in /opt/local/var/macports/build/_Users_rschmidt_macports_dports_science_ccpnmr/work/ccpnmr/ccpnmr2.1/c/memops/global/macros.h

Should I remove them?

Yes. Those can be removed for ccpnmr 2.1.5.

Nix that. I am finding that at least the PREFIX change is need here. Can you actually rebuild ccpnmr-2.1.5 with those two reinplaces removed?

comment:6 Changed 10 years ago by howarth@…

I can only drop...

     reinplace  "s|malloc.h|sys/malloc.h|g" ${worksrcpath}/ccpnmr${branch}/c/memops/global/macros.h

here without breaking the ccpnmr 2.1.5 build.

comment:7 Changed 10 years ago by ryandesign (Ryan Schmidt)

As the error message said, the reinplaces for malloc.h and @PYTHON_LIB@ don't do anything, so yes, I can build the port without both of them. The other reinplaces, for @PYTHON_BIN@, @PYTHON_INCL@, @PYTHON_PKGD@, @PREFIX@ and /usr/X11R6, stay. I don't know if you perhaps meant to have the @PYTHON_LIB@ placeholder inserted somewhere in environment-opengl.txt, but your current patch doesn't do so.

comment:8 Changed 10 years ago by howarth@…

My mistake as I misread your original note. It is okay to remove both the reinplaces for malloc.h and @PYTHON_LIB@. FYI, you can confirm that the package runs by executing 'analysis'.

comment:9 in reply to:  8 Changed 10 years ago by ryandesign (Ryan Schmidt)

Replying to howarth@…:

FYI, you can confirm that the package runs by executing 'analysis'.

This gives me:

Traceback (most recent call last):
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/site-packages/ccpnmr/ccpnmr2.1/python/ccpnmr/analysis/AnalysisGui.py", line 46, in <module>
    import Tkinter
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/lib-tk/Tkinter.py", line 39, in <module>
    import _tkinter # If this fails your Python may not be configured for Tk
ImportError: No module named _tkinter
>>> 

After installing py26-tkinter, analysis opens and shows its X11 menu. Should I add py26-tkinter as a dependency?

Changed 10 years ago by howarth@…

Attachment: Portfile.diff added

corrected Portfile diff for ccpnmr 2.1.5

comment:10 Changed 10 years ago by howarth@…

Yes, We need to add a depends-lib on port:py26-tkinter. I've uploaded a corrected Portfile.diff with the reinplace's on malloc.h and @PYTHON_LIB@ removed and the port:py26-tkinter dependency added.

comment:11 Changed 10 years ago by nerdling (Jeremy Lavergne)

Resolution: fixed
Status: assignedclosed

Updated in r75128.

Note: See TracTickets for help on using tickets.