#27989 closed submission (fixed)
Portfile for Darktable
| Reported by: | julians37@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.9.2 |
| Keywords: | Cc: | ||
| Port: | darktable |
Description
Portfile for Darktable, a virtual lighttable and darkroom for photographers.
I've tested building this on a secondary MacPorts installation from scratch and so I'm reasonably confident that it has all needed dependencies. I've also tested building the +universal variant.
It depends on lensfun which also isn't in Macports yet, ticket #27986 has its portfile.
Attachments (2)
Change History (7)
Changed 13 years ago by julians37@…
Changed 13 years ago by julians37@…
| Attachment: | exiv2_headers.diff added |
|---|
comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Owner: | changed from macports-tickets@… to ryandesign@… |
|---|---|
| Port: | darktable added |
| Status: | new → assigned |
comment:2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Committed in r75148 with these changes:
- added lensfun dependency
- rewrote glib2 and cairo dependencies so that glib2-devel and cairo-devel, respectively, could satisfy them
- removed md5 checksum which I consider to be obsolete
- renamed patchfile
- slight reformatting
comment:3 follow-up: 4 Changed 13 years ago by julians37@…
Whoops, how did the lensfun dependency get lost!
May I suggest to add the following to the guide, unless I have missed them:
- Patch file naming conventions
- md5 checksum being obsolete
- Best practices regarding xxx-devel dependency satisfaction
Thanks again.
comment:4 follow-up: 5 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to julians37@…:
- Patch file naming conventions
This should be documented here.
- md5 checksum being obsolete
I think this is a good practice, but I've only just brought it up on the mailing list, where we'll see if we agree we should make it an official recommendation.
- Best practices regarding xxx-devel dependency satisfaction
Nothing about -devel ports is currently documented; the request to do so is #14540.
comment:5 Changed 13 years ago by julians37@…
Replying to ryandesign@…:
Replying to julians37@…:
- Patch file naming conventions
This should be documented here.
By this you mean it *is* documented there - must have missed that.
- md5 checksum being obsolete
I think this is a good practice, but I've only just brought it up on the mailing list, where we'll see if we agree we should make it an official recommendation.
For what it's worth, I agree that three checksums is overkill.
Thanks.