VLC @1.0.6, Revision 3 - upgrade from 1.0.6_2 to 1.0.6_3 fails.

[nonstop.server@…]

Upgrading VLC from version 1.0.6_2 to version 1.0.6_3 fail with the following errors:

In file included from /opt/local/include/zlib.h:34,
                 from /opt/local/include/png.h:405,
                 from png.c:35:
/opt/local/include/zconf.h:397:37: warning: "_LFS64_LARGEFILE" is not defined
In file included from /opt/local/include/png.h:405,
                 from png.c:35:
/opt/local/include/zlib.h:1565:37: warning: "_LFS64_LARGEFILE" is not defined
/opt/local/include/zlib.h:1574:61: warning: "_LFS64_LARGEFILE" is not defined
png.c: In function 'DecodeBlock':
png.c:158: error: 'png_infopp_NULL' undeclared (first use in this function)
png.c:158: error: (Each undeclared identifier is reported only once
png.c:158: error: for each function it appears in.)
make[5]: *** [libpng_plugin_la-png.lo] Error 1
make[4]: *** [all-recursive] Error 1
make[3]: *** [all] Error 2
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_multimedia_VLC/work/vlc-1.0.6" && /usr/bin/make all " returned error 2
Error: Target org.macports.build returned: shell command failed (see log for details)
DEBUG: Backtrace: shell command failed (see log for details)
    while executing
"command_exec build"
    (procedure "portbuild::build_main" line 8)
    invoked from within
"$procedure $targetname"
Warning: the following items did not execute (for VLC): org.macports.destroot org.macports.build
Log for VLC is at: /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_multimedia_VLC/main.log
DEBUG: invalid command name "::ui_init"
    while executing
"::ui_init any stdout"
    ("eval" body line 1)
    invoked from within
"eval ::ui_init $priority $prefix $channels($priority) $args"
    ("uplevel" body line 2)
    invoked from within
"uplevel 1 $body"
Error: Unable to upgrade port: 1

My version information is:

MacPorts
Version: 1.9.2

Xcode
Xcode 3.1.4
Component versions: DevToolsCore-1204.0; DevToolsSupport-1186.0
BuildVersion: 9M2809

Mac OS X
Darwin 9.8.0 Darwin Kernel Version 9.8.0: Wed Jul 15 16:55:01 PDT 2009;
root:xnu-1228.15.4~1/RELEASE_I386 i386

Please see the attached log for a complete list of error messages.

[ryandesign (Ryan Carsten Schmidt)]

Undoubtedly an incompatibility with the recently updated libpng 1.4.x.

Perhaps updating the VLC port to the latest version would help; this has been long requested in #25431.

[jwhowse4]

I am having the exact same compiling error on an Intel Mac Pro running Snow Leopard 10.6.6 and XCode 3.2.5. Perhaps an upgrade to VLC version 1.1.5 is needed?

[carsomyr@…]

The error is because of a libpng upgrade from 1.2.44 to 1.4.5, which took out the rather superfluous "png_infopp_NULL" macro, which is just "(png_infopp) NULL". Making this replacement in png.c causes the build to go through. Please find the attached patch archive.

[carsomyr@…]

The Port patch.

[jmroot (Joshua Root)]

Thanks, applied in r75204.