Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#28199 closed defect (fixed)

emacs-app: a small fix and cleanup

Reported by: carsomyr@… Owned by: cssdev
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc: vinc17@…
Port: emacs-app

Description

I've attached a patch for emacs-app that applies this fix:

http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-23&id=f9e7c41d1d18300fac79b2bfaa47d7db0687ad04

In short, it enables you to use Emacs.app from the command line, where previously expansion of relative pathnames for opening files was broken. Also, the Port patch cleans up the fullscreen patch by making it MacPorts compliant. Please find attached the patch archive patch-emacs-app.tgz.

Attachments (1)

patch-emacs-app.tgz (2.4 KB) - added by carsomyr@… 10 years ago.
The Port patch archive.

Download all attachments as: .zip

Change History (11)

Changed 10 years ago by carsomyr@…

Attachment: patch-emacs-app.tgz added

The Port patch archive.

comment:1 Changed 10 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to css@…
Port: emacs-app added
Summary: A small fix and cleanup for emacs-appemacs-app: a small fix and cleanup

comment:2 Changed 10 years ago by cssdev

Status: newassigned

comment:3 Changed 10 years ago by cssdev

I just did a clean system install, so I need to set aside some time tonight to run the build and all its dependencies. Thanks for the patch!

comment:4 Changed 10 years ago by vinc17@…

Cc: vinc17@… added

Cc Me!

comment:5 Changed 10 years ago by vinc17@…

Type: enhancementdefect

Any news? Is there any reason that the patch haven't been committed yet?

Note that this is a regression compared to Emacs 22 (provided by an old version of the emacs port).

comment:6 in reply to:  5 ; Changed 10 years ago by carsomyr@…

Replying to vinc17@…:

Any news? Is there any reason that the patch haven't been committed yet?

Note that this is a regression compared to Emacs 22 (provided by an old version of the emacs port).

How is it a regression? Are you saying that the bug didn't happen in earlier versions?

comment:7 in reply to:  6 ; Changed 10 years ago by vinc17@…

Replying to carsomyr@…:

How is it a regression? Are you saying that the bug didn't happen in earlier versions?

There was no such problem with Emacs 22. Then, I don't know when it appeared, but the bug was first reported upstream on 13 May 2010, against Emacs 23.2: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6179

comment:8 in reply to:  7 ; Changed 10 years ago by carsomyr@…

Replying to vinc17@…:

Replying to carsomyr@…:

How is it a regression? Are you saying that the bug didn't happen in earlier versions?

There was no such problem with Emacs 22. Then, I don't know when it appeared, but the bug was first reported upstream on 13 May 2010, against Emacs 23.2: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6179

Oh yeah, that was me trying to patch the bug when I didn't come up with the correct fix. Are you saying that ns-win.el somehow regressed from 22 to 23.2?

comment:9 Changed 10 years ago by cssdev

Resolution: fixed
Status: assignedclosed

Constrained mental bandwidth on my part, sorry. This got lost in the shuffle. Tested and committed to r76517. Thanks for the reminder! :)

comment:10 in reply to:  8 Changed 10 years ago by vinc17@…

Replying to carsomyr@…:

Oh yeah, that was me trying to patch the bug when I didn't come up with the correct fix. Are you saying that ns-win.el somehow regressed from 22 to 23.2?

Emacs 22 doesn't have a ns-win.el, so that I assume that the implementation significantly changed and a new bug (that was not present in Emacs 22) has been introduced. In any case, the problem appeared just after I upgraded from Emacs 22 to Emacs 23.2.

Note: See TracTickets for help on using tickets.