Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#28253 closed defect (fixed)

science/hdf5-18 does not build all shared libraries

Reported by: daniel.hornung@… Owned by: mamoll (Mark Moll)
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc:
Port: hdf5-18

Description

Due to an upstream configure bug on Macs, HDF5's configure disables the building of shared libraries if the --disable-fortran configure option is given.

The patch shipped with the current port works around this bug partially, but not completely (only some shared libraries are being built).

Replacing the current patch (patch-configure.diff) with the one attached to this ticket works at least on my machine (OS X 10.5).


Explanation of the problem:

Currently the file config/apple (in the HDF5 archive) checks if the variable "enable_fortran" is non-empty, if it is, shared libraries are disabled. With the --disable-fortran configure option, this variable is set to "no", so the test returns true, also disabling the building of shared libraries. The attached patch now tests the value of the variable against "yes", only then shared libraries are disabled, yielding the correct behavior.

Attachments (2)

apple_fortran_config.patch (420 bytes) - added by daniel.hornung@… 10 years ago.
Patch for config/apple
Portfile_hdf5-18_apple_fortran.diff (418 bytes) - added by daniel.hornung@… 10 years ago.
Patch for the portfile

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by daniel.hornung@…

Attachment: apple_fortran_config.patch added

Patch for config/apple

Changed 10 years ago by daniel.hornung@…

Patch for the portfile

comment:1 Changed 10 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to mmoll@…
Port: hdf5-18 added

comment:2 Changed 10 years ago by mamoll (Mark Moll)

Which shared libraries are not being built currently?

comment:3 Changed 10 years ago by daniel.hornung@…

libhdf5_cpp.6.dylib and libhdf5_hl_cpp.6.dylib (and the symlinks to them)

comment:4 Changed 10 years ago by mamoll (Mark Moll)

Resolution: fixed
Status: newclosed

Committed in r75662. I use the parallel variant which disables the C++ bindings, so I never noticed the missing C++ libs. Thanks for the patch. I'll email the hdf5 mailing list, so that hopefully it'll get fixed upstream.

comment:5 in reply to:  4 Changed 10 years ago by daniel.hornung@…

Replying to mmoll@…:

Committed in r75662.

Thanks!

I'll email the hdf5 mailing list, so that hopefully it'll get fixed upstream.

That's probably not necessary (but won't harm either), I emailed the help@… address and have the impression that this will make it into their next bugfix release anyway.

Note: See TracTickets for help on using tickets.