Opened 10 years ago

Closed 10 years ago

#28324 closed defect (fixed)

libsamplerate: samplerate.h has comma at end of enumerator list

Reported by: ryandesign (Ryan Schmidt) Owned by: boeyms@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch Cc:
Port: libsamplerate

Description

When trying to compile darkice (#24867) with its +samplerate variant, I get this error:

In file included from VorbisLibEncoder.h:56,
                 from DarkIce.cpp:92:
/opt/local/include/samplerate.h:177: error: comma at end of enumerator list

It seems having a comma at the end of an enumerated list is valid in C99 but not C89, and if another project is compiling with -pedantic then it will encounter this error.

When we've had other ports in the past that have had this error (e.g. cairo in #26806) we've fixed them; perhaps we can fix this in libsamplerate too.

Attachments (1)

libsamplerate.diff (1.1 KB) - added by ryandesign (Ryan Schmidt) 10 years ago.
proposed patch

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by ryandesign (Ryan Schmidt)

Attachment: libsamplerate.diff added

proposed patch

comment:1 Changed 10 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added

comment:2 Changed 10 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed

r75920 (maintainer timeout)

Note: See TracTickets for help on using tickets.