Opened 10 years ago

Closed 10 years ago

#28353 closed update (fixed)

eggdrop: update to 1.6.20

Reported by: dreness (Andre LaBranche) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch maintainer Cc:
Port: eggdrop

Description

Attaching two files; an updated Portfile and updated Makefile.in patch file.

Attachments (4)

Portfile (1.1 KB) - added by dreness (Andre LaBranche) 10 years ago.
Portfile
patch-Makefile.in.diff (428 bytes) - added by dreness (Andre LaBranche) 10 years ago.
Makefile.in patch
portfile.diff (928 bytes) - added by dreness (Andre LaBranche) 10 years ago.
Portfile diff
patch.diff (878 bytes) - added by dreness (Andre LaBranche) 10 years ago.
patch diff

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by dreness (Andre LaBranche)

Attachment: Portfile added

Portfile

Changed 10 years ago by dreness (Andre LaBranche)

Attachment: patch-Makefile.in.diff added

Makefile.in patch

comment:1 Changed 10 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Port: eggdrop added
Status: newassigned

This had been requested in #28295.

comment:2 Changed 10 years ago by ryandesign (Ryan Schmidt)

Please submit a portfile diff, not a full portfile. Your full portfile that you submitted is based on an outdated portfile. Please consult the repository and obtain the latest current eggdrop portfile, then make your changes based on that, then submit a diff of it.

Changed 10 years ago by dreness (Andre LaBranche)

Attachment: portfile.diff added

Portfile diff

Changed 10 years ago by dreness (Andre LaBranche)

Attachment: patch.diff added

patch diff

comment:3 in reply to:  2 Changed 10 years ago by dreness (Andre LaBranche)

Replying to ryandesign@…:

Please submit a portfile diff, not a full portfile. Your full portfile that you submitted is based on an outdated portfile. Please consult the repository and obtain the latest current eggdrop portfile, then make your changes based on that, then submit a diff of it.

Added the two requested diffs.

comment:4 Changed 10 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch maintainer added
Resolution: fixed
Status: assignedclosed
Summary: Bump eggdrop to 1.6.20eggdrop: update to 1.6.20

Thanks. That portfile diff allowed me to see what changes you wanted us to make, and I made them in r75864. However, your patch would not apply to the portfile in the repository; it was made against an earlier version of the portfile. Please always submit diffs made against the current version of the portfile in the repository.

Note also that we don't need diffs of your patchfiles, just of portfiles.

Note: See TracTickets for help on using tickets.