Opened 10 years ago

Closed 8 years ago

#28394 closed enhancement (fixed)

Enable apple_media for gst-plugins-bad

Reported by: gosuperninja@… Owned by: rmstonecipher@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch Cc: robink@…
Port: gst-plugins-bad

Description

The apple media plugins are being disabled from the gst-plugins-bad build. I enabled it on a x86_64 snow leopard system, it built fine.

Attachments (1)

patch-sys-applemedia-Makefile.in.diff (317 bytes) - added by andres.colubri@… 9 years ago.
Fixed 32 bits build of applemedia

Download all attachments as: .zip

Change History (12)

comment:1 Changed 10 years ago by gosuperninja@…

Cc: gosuperninja@… added

Cc Me!

comment:2 Changed 10 years ago by mf2k (Frank Schima)

Cc: gosuperninja@… removed
Keywords: apple_media applemedia removed
Owner: changed from macports-tickets@… to rmstonecipher@…
Type: requestenhancement

comment:3 Changed 10 years ago by rmstonecipher@…

Go Super Ninja,
I added the '--disable-apple-media' configure argument because apple_media plugins failed to build +universal.
If you can figure out a way to build for i386 without apple_media and for x86_64 with apple_media I'd be all for enabling as much as possible on each architecture.

Cheers,
Ryan Stonecipher

comment:4 Changed 9 years ago by jmroot (Joshua Root)

Declaring the apple_media variant as conflicting with universal would also be an option.

comment:5 Changed 9 years ago by gosuperninja@…

I can make a patch for the auto config to test for i386. But I don't know how to specifically test for that. Do you know?

comment:6 in reply to:  5 Changed 9 years ago by derekanoble@…

Replying to gosuperninja@…:

I can make a patch for the auto config to test for i386. But I don't know how to specifically test for that. Do you know?

I've been trying to build applemedia for i386 and was successful today (built, not tested yet). Issue seems to be that applemedia has Objective C source files (.m) with associated rules in the Makefile which reference OBJCFLAGS for the compile flags. OBJCFLAGS is never defined. I cloned a line in the Makefile to set OBJCFLAGS the same as CFLAGS and the build worked. I have gst-plugins-bad built / installed for i386.

I'm a make noob so hopefully this points y'all in the right direction for a proper solution.

...Derek

comment:7 Changed 9 years ago by rmstonecipher@…

Derek,
Could you upload a patch made using the technique described in the MacPorts Guide?
I would like to test your solution, commit the patch, and submit it to the upstream developers.

Cheers,
Ryan Stonecipher

Changed 9 years ago by andres.colubri@…

Fixed 32 bits build of applemedia

comment:8 Changed 9 years ago by andres.colubri@…

Hi, I prepared a small patch that fixes the 32 bits compilation of applemedia, based on the observation from Derek.

comment:9 Changed 9 years ago by jmroot (Joshua Root)

Keywords: haspatch added

comment:10 Changed 8 years ago by robink@…

Cc: robink@… added

Cc Me!

comment:11 Changed 8 years ago by rmstonecipher@…

Resolution: fixed
Status: newclosed

Fixed in r99333.

Note: See TracTickets for help on using tickets.