checksum phase runs twice: to test and to print expected values

[nerdling (Jeremy Lavergne)]

Presently, checksums are run when testing the distfiles. They also get run again to produce the expected values that are displayed for verbose mode.

Checksum phase should run once, and the output reused.

base/src/port1.0/portchecksum.tcl

Marking as enhancement for 2.0.0 as this could definitely be improved.

[jmroot (Joshua Root)]

r84985

[jmroot (Joshua Root)]

The fix is partially incorrect; it prints an invalid checksums line when there are multiple distfiles.

[nerdling (Jeremy Lavergne)]

Hmm, I'm not seeing that behavior:

--->  Fetching xforms
DEBUG: euid/egid changed to: 0/0
DEBUG: chowned /opt/local/var/macports/distfiles/xforms/1.0.93sp1_0 to macports
DEBUG: euid/egid changed to: 509/515
DEBUG: Executing org.macports.fetch (xforms)
DEBUG: Privilege de-escalation not attempted as not running as root.
DEBUG: checksum phase started at Thu Dec  1 11:16:53 EST 2011
--->  Verifying checksum(s) for xforms
DEBUG: Executing org.macports.checksum (xforms)
--->  Checksumming xforms-1.0.93sp1.tar.gz
DEBUG: Correct (md5) checksum for xforms-1.0.93sp1.tar.gz
DEBUG: Correct (sha1) checksum for xforms-1.0.93sp1.tar.gz
DEBUG: Correct (rmd160) checksum for xforms-1.0.93sp1.tar.gz
--->  Checksumming xforms.html.tar.gz
DEBUG: Correct (md5) checksum for xforms.html.tar.gz
DEBUG: Correct (sha1) checksum for xforms.html.tar.gz
DEBUG: Correct (rmd160) checksum for xforms.html.tar.gz
--->  Checksumming xforms.pdf
DEBUG: Correct (md5) checksum for xforms.pdf
DEBUG: Correct (sha1) checksum for xforms.pdf
DEBUG: Correct (rmd160) checksum for xforms.pdf

Do you have a specific port that I can test?

[raimue (Rainer Müller)]

I can reproduce the problem mentioned by jmr. The problem is that the proposed checksums line in "The correct checksum line may be:" lists the names of the distfiles at the end. Or whatever it does, it is not valid...

To reproduce the problem I replaced some of the checksums in the xforms port with an "x":

--->  Verifying checksum(s) for xforms
--->  Checksumming xforms-1.0.93sp1.tar.gz
Error: Checksum (md5) mismatch for xforms-1.0.93sp1.tar.gz
Portfile checksum: xforms-1.0.93sp1.tar.gz md5 x
Distfile checksum: xforms-1.0.93sp1.tar.gz md5 68ed76216be9b09032e22736d95c8b3c
Error: Checksum (sha1) mismatch for xforms-1.0.93sp1.tar.gz
Portfile checksum: xforms-1.0.93sp1.tar.gz sha1 x
Distfile checksum: xforms-1.0.93sp1.tar.gz sha1 a2c52f44ef4b20fc9002615f978eb49c79f63cd2
Error: Checksum (rmd160) mismatch for xforms-1.0.93sp1.tar.gz
Portfile checksum: xforms-1.0.93sp1.tar.gz rmd160 x
Distfile checksum: xforms-1.0.93sp1.tar.gz rmd160 cb094dbeb96b5adaa105e8f53ddbe5e452a0978e
--->  Checksumming xforms.html.tar.gz
--->  Checksumming xforms.pdf
The correct checksum line may be:
checksums           md5     68ed76216be9b09032e22736d95c8b3c \
                    sha1    a2c52f44ef4b20fc9002615f978eb49c79f63cd2 \
                    rmd160  cb094dbeb96b5adaa105e8f53ddbe5e452a0978e \
                    md5     d89e634753ad349b281b072c84182aa6 \
                    sha1    7faa22e809dfec207931237bebd1572ff0a488c1 \
                    rmd160  1c2054aeead5031bff8fcdd5f38715247d0b62e7 \
                    md5     0080f2d50d76b8245bd63ee1d821b147 \
                    sha1    187e653fbae01f4652e2aa35a8f4806b4ae5abbc \
                    rmd160  e49a6f0d8485f72ef2ab93dba7e6f23b3132b9d9 \
                    xforms-1.0.93sp1.tar.gz \
                    xforms.html.tar.gz \
                    xforms.pdf

[nerdling (Jeremy Lavergne)]

Ah, thanks Raim. I couldn't see that before.

[nerdling (Jeremy Lavergne)]

Corrected in r87688.

[nerdling (Jeremy Lavergne)]

and r87689.

[nerdling (Jeremy Lavergne)]

and finally r87693.