Opened 13 years ago

Closed 13 years ago

#28730 closed defect (fixed)

Node.js doesn't use the right compiler

Reported by: ci42 Owned by: ceager@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch Cc:
Port: nodejs

Description

Configure in node.js does not set the compiler and therefor the default compiler will be used. This could be a problem (see https://trac.macports.org/wiki/UsingTheRightCompiler)

The attached patch sets appropriate flags in the build phase as suggested in the above-mentioned document.

Attachments (1)

nodejs.diff (1.2 KB) - added by ci42 13 years ago.
update to nodejs v0.4.3

Download all attachments as: .zip

Change History (4)

comment:1 Changed 13 years ago by jmroot (Joshua Root)

Keywords: haspatch added
Owner: changed from macports-tickets@… to ceager@…

Please remember to cc the maintainer.

You'll also want to include configure.cc_archflags and configure.ld_archflags in CFLAGS and LDFLAGS respectively so that build_arch is obeyed.

comment:2 in reply to:  1 Changed 13 years ago by ci42

You'll also want to include configure.cc_archflags and configure.ld_archflags in CFLAGS and LDFLAGS respectively so that build_arch is obeyed.

Updated the patch accordingly.

Changed 13 years ago by ci42

Attachment: nodejs.diff added

update to nodejs v0.4.3

comment:3 Changed 13 years ago by raimue (Rainer Müller)

Resolution: fixed
Status: newclosed

Committed in r77583.

Note: See TracTickets for help on using tickets.