Opened 13 years ago

Closed 13 years ago

#28799 closed submission (fixed)

New port: Play framwork

Reported by: ci42 Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc: raimue (Rainer Müller)
Port: play

Description

Port for the rapid webapplication framework: play framework

Attachments (4)

play.diff (5.6 KB) - added by ci42 13 years ago.
Portfile and patches
play.2.diff (5.3 KB) - added by ci42 13 years ago.
play.3.diff (5.3 KB) - added by ci42 13 years ago.
play.4.diff (5.2 KB) - added by ci42 13 years ago.
update to play version 1.2

Download all attachments as: .zip

Change History (12)

Changed 13 years ago by ci42

Attachment: play.diff added

Portfile and patches

comment:1 Changed 13 years ago by raimue (Rainer Müller)

The long_description contains some non-ASCII characters.

When using github, you should download using HTTP to avoid git as a dependency and make a distfile we can mirror. See the MacVim port as an example.

comment:2 Changed 13 years ago by raimue (Rainer Müller)

Also, license option should be set according to this draft?:

license Apache-2

Changed 13 years ago by ci42

Attachment: play.2.diff added

comment:3 Changed 13 years ago by ci42

Updated the patch. Changes:

  • clean up long_description (remove non-ASCII characters)
  • fetch sources over http instead of git
  • rename licence from "Apache Licence 2.0" to "Apache-2"

comment:4 Changed 13 years ago by raimue (Rainer Müller)

Cc: raimue@… added
Port: play added

The worksrcdir option is being changed in the pre-build phase. This makes it impossible to run build and destroot as separate steps. Either set this only once on the top-level or use build.dir/destroot.dir instead to switch the working directory for the command.

Why is the executable being installed into share and not directly into bin? Does it have to be in the same directory as any resources?

Changed 13 years ago by ci42

Attachment: play.3.diff added

comment:5 in reply to:  4 ; Changed 13 years ago by ci42

Replying to raimue@…:

The worksrcdir option is being changed in the pre-build phase. This makes it impossible to run build and destroot as separate steps. Either set this only once on the top-level or use build.dir/destroot.dir instead to switch the working directory for the command.

This was a workaround when I initially fetched the source with git (first patch). These got fetched to the wrong directory because $worksrcpath is defined in terms of $worksrcdir (see portmain.tcl) and portfetch::gitfetch clones the sources to $worksrcpath. This means changing $worksrcdir causes git.fetch (and hg.fetch too) to use the wrong directory. I open a separate ticket for this after further investigation.

I wasn't aware of the 'build.dir' variable, there is no reference in the documentation (except for the somewaht unrelated xcode portgroup). The updated patch uses the 'build.dir' instead of changing the 'worksrcdir'.

Why is the executable being installed into share and not directly into bin? Does it have to be in the same directory as any resources?

Indeed. It expects to be located in the same directory as "framework", "documentation", "resources", "modules" and "repositories"

comment:6 in reply to:  5 Changed 13 years ago by ci42

Replying to ciserlohn@…:

This was a workaround when I initially fetched the source with git (first patch). These got fetched to the wrong directory because $worksrcpath is defined in terms of $worksrcdir (see portmain.tcl) and portfetch::gitfetch clones the sources to $worksrcpath. This means changing $worksrcdir causes git.fetch (and hg.fetch too) to use the wrong directory. I will open a separate ticket for this after further investigation.

see #29093

Changed 13 years ago by ci42

Attachment: play.4.diff added

update to play version 1.2

comment:7 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Thanks.

comment:8 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Added in r78267 with these changes:

  • reformatted and reordered the portfile a little
  • added www category
  • don't use "system" just to create symlinks
  • added "supported_archs noarch" because this installs no architecture-specific files
  • added "conflicts sox" because sox also wants to install a program called "play"

It would be nice not to have this conflict. Can the play port install a differently-named program?

Note: See TracTickets for help on using tickets.