Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#28998 closed submission (fixed)

snappy @1.0.1 - New Port

Reported by: sepp@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc: blb@…, ryandesign (Ryan Carsten Schmidt)
Port: snappy

Description

Google has released their new library for compression/decompression.

Port snappy contains:
  /opt/local/include/snappy-sinksource.h
  /opt/local/include/snappy-stubs-public.h
  /opt/local/include/snappy.h
  /opt/local/lib/libsnappy.1.dylib
  /opt/local/lib/libsnappy.a
  /opt/local/lib/libsnappy.dylib
  /opt/local/lib/libsnappy.la
  /opt/local/share/doc/snappy/ChangeLog
  /opt/local/share/doc/snappy/COPYING
  /opt/local/share/doc/snappy/INSTALL
  /opt/local/share/doc/snappy/NEWS
  /opt/local/share/doc/snappy/README

Attachments (2)

Portfile (1009 bytes) - added by sepp@… 13 years ago.
Portfile.2 (1.0 KB) - added by sepp@… 13 years ago.

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by sepp@…

Attachment: Portfile added

comment:1 Changed 13 years ago by blb@…

A couple of initial observations:

  • port lint would like a platforms key (usually just platforms darwin)
  • it also wants an Id line, which you have but not in subversion's exact format; I usually just start with # $Id$ in a new Portfile
  • Looks like this links against both liblzo2 and libz when available from MacPorts (according to an otool -L here); should those be listed as dependencies or is there a way to disable such linking?

comment:2 in reply to:  1 Changed 13 years ago by sepp@…

Thanks for the hints. I'll remember those for future Portfiles.

I'll attach a new Portfile which should be fine now.

Changed 13 years ago by sepp@…

Attachment: Portfile.2 added

comment:3 Changed 13 years ago by blb@…

Resolution: fixed
Status: newclosed

Added in r77558, thanks.

comment:4 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: blb@… ryandesign@… added

I've made some changes, which I would have liked to see included in the initial commit:

  • r77604: fixed whitespace to use spaces not tabs; added modeline; reordered some lines
  • r77605: simplified master_sites to just "googlecode"
  • r77606: removed unnecessary "configure.args --prefix=${prefix}"; MacPorts already puts --prefix=${prefix} in configure.pre_args for you
  • r77607: fixed typo in description
  • r77608: fixed license (1.0.1 is under the Apache 2.0 license; looks like future versions will be under the BSD license)

comment:5 in reply to:  4 Changed 13 years ago by blb@…

Replying to ryandesign@…:

I've made some changes, which I would have liked to see included in the initial commit:

  • r77604: fixed whitespace to use spaces not tabs; added modeline; reordered some lines

Does this mean MacPorts now has a particular whitespace requirement?

Note: See TracTickets for help on using tickets.