Opened 13 years ago
Closed 13 years ago
#29160 closed submission (fixed)
crfpp @ 0.54 - new port
| Reported by: | humem (humem) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.9.2 |
| Keywords: | science | Cc: | |
| Port: | crfpp |
Description
This is a Portfile for CRF++, Yet Another CRF toolkit.
Attachments (2)
Change History (7)
Changed 13 years ago by humem (humem)
comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Owner: | changed from macports-tickets@… to ryandesign@… |
|---|---|
| Status: | new → assigned |
comment:2 follow-up: 3 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
What is the reason for running autoreconf? Usually we do that if we patch configure.ac, and thus need autoreconf to regenerate configure. We might also use autoreconf to regenerate configure if it was made with a very old version of autoconf that doesn't support universal builds (i.e. doesn't pass -arch flags along). It doesn't look like either reason applies here.
comment:3 Changed 13 years ago by humem (humem)
Replying to ryandesign@…:
What is the reason for running autoreconf? Usually we do that if we patch configure.ac, and thus need autoreconf to regenerate configure. We might also use autoreconf to regenerate configure if it was made with a very old version of autoconf that doesn't support universal builds (i.e. doesn't pass
-archflags along). It doesn't look like either reason applies here.
Thanks a lot for your comment! I tried to build the port with a universal variant and found it did not work properly. Although autoreconf is not necessary as you pointed out, I have no idea how to fix the port to enable universal builds. Should I put universal_variant no in the port?
Changed 13 years ago by humem (humem)
| Attachment: | Portfile.2 added |
|---|
comment:4 Changed 13 years ago by humem (humem)
I added Portfile.2 that enables a universal build as well as the bact port does. Could you please check the port? Thanks in advance.
comment:5 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Committed in r78009 with these changes:
- did not commit the universal directives you proposed because they are not necessary for a project like crfpp that uses a standard autoconf-based configure script; the only reason universal didn't work here was that the developers unwisely decided in their configure script to override our CFLAGS and CXXFLAGS; I added a patch to correct that.
- simplified master_sites to just "sourceforge"
- just set distname instead of setting both distfiles and worksrcdir
- don't autoreconf (accidentally left it in the portfile, commented out; removed it entirely in r78010)
Thanks.