Opened 13 years ago

Closed 13 years ago

#29267 closed defect (fixed)

portinstall.tcl incorrectly ignores directory symlinks

Reported by: carsomyr@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: base Version: 1.9.99
Keywords: Cc:
Port:

Description

When crawling the destroot for files to register, portinstall.tcl ignores directories. Unfortunately, it also ignores symlinks that point to directories. The following patch rectifies this problem:

--- base/src/port1.0/portinstall.tcl	(revision 78141)
+++ base/src/port1.0/portinstall.tcl	(working copy)
@@ -308,7 +308,7 @@
     # also save the contents for our own use later
     set installPlist {}
     fs-traverse -depth fullpath $destpath {
-        if {[file isdirectory $fullpath]} {
+        if {[file isdirectory $fullpath] && [file type $fullpath] != "link"} {
             continue
         }
         set relpath [strsed $fullpath "s|^$destpath/||"]

In other words, a file is ignored iff it is a directory and NOT a symlink.

Change History (1)

comment:1 Changed 13 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed
Version: 1.9.21.9.99
Note: See TracTickets for help on using tickets.