tortoisehg: add launcher icon and gui ssh-askpass

[shiena.jp@…]

About launcher icon

Because TortoiseHg had a good logo, it converted it into the icon according to the following procedures.

1. get thg_logo.svg from ​https://bitbucket.org/tortoisehg/thg/src/47ff626c895d/icons/svg/thg_logo.svg
2. convert thg_logo.svg into tiff of width:128px and height:128px. I did export to png of 128x128 pixel with Inkscape, and converted it into tiff by the convert command of ImageMagick.
3. converts it into the icns by the tiff2icns command.

About gui ssh-askpass

It fails in the connection of the ssh server for which the password is necessary because osx doesn't have ssh-askpass. Then, it comes to be able to input the password by using this macos-askpass. I built this in tortoisehg.

​http://blogs.oracle.com/mock/entry/and_now_chicken_of_the

[jmroot (Joshua Root)]

Please remember to cc the maintainer.

[ryandesign (Ryan Carsten Schmidt)]

I had been working with the developer and maintainer of our makeicns tool to get it to process non-square images, like TortoiseHg's logo, but converting the svg to icns didn't produce an icon that was the same as theirs. I also tried ImageMagick to convert it but that wasn't satisfactory either. I didn't try an intermediate step through Inkscape though.

[pixilla (Bradley Giesbrecht)]

I haven't found a good svg converter but there is a 368 × 220 png that makes a decent icon. We have not yet added padding to makeicns. ImageMagick's convert can be used in the mean time. Something like this should do it.

depends_build    port:makeicns port:ImageMagick
post-extract {
    system "convert ${worksrcpath}/doc/source/figures/thg_logo_pdf.png \
        -background transparent \
        -gravity center \
        -resize 512x512 \
        -extent 512x512 \
        ${worksrcpath}/tortoisehg.png
    system "makeicns -in ${worksrcpath}/tortoisehg.png \
        -out ${worksrcpath}/tortoisehg.icns"
}

[mkae (Marko Käning)]

Version 1.4.8 now supports non-square icons and would center the icon by default. Left, right, top, and bottom alignment are also possible.

[mkae (Marko Käning)]

Replying to mk@…:

Version 1.4.8

... being the version of makeicns. :-)

[ryandesign (Ryan Carsten Schmidt)]

Yes, but the icon makeicns generated did not look like the icon TortoiseHg already uses once it launches. So this would result in a jarring transition in the dock icon. I have not yet tested whether the icon attached here has the same problem.

[mkae (Marko Käning)]

Cc Me!

[mkae (Marko Käning)]

I see now what you mean, Ryan. The changing image issue could be caused by PyQt...

[mkae (Marko Käning)]

Yep, if you look into /Applications/MacPorts/Python 2.7 you'll see that the Python launcher actually uses this rocket icon which then gets replaced by the tortoise. :-) So, I guess one would need to teach the launcher that it shouldn't show its icon during its own startup.

[shiena.jp@…]

How about librsvg's rsvg-convert? It was possible to convert it into non-square icon.

depends_build       port:librsvg \
                    port:makeicns
platform darwin {
    set appname {TortoiseHg}
    post-extract {
        copy ${filespath}/${appname}.in ${workpath}/${appname}
        system "rsvg-convert ${worksrcpath}/icons/svg/thg_logo.svg \
            --format=png \
            --width=512 \
            --height=512 \
            --output=${workpath}/${appname}.png"
        system "makeicns -in ${workpath}/${appname}.png \
            -out ${workpath}/${appname}.icns"
    }
}

[mkae (Marko Käning)]

Yep, Brad was thinking about using libsrvg as well. Unfortunately it is a quite large port which could be stripped to a large extend for the same functionality delivered by rsvg-convert. We're pondering the idea to use rsvg-convert in makeicns in the future.

[mkae (Marko Käning)]

And, I hope it might not be necessary anymore to specify width and height in rsvg-convert... (Haven't tested that though.)

[ryandesign (Ryan Carsten Schmidt)]

Now that we have the app portgroup, I updated tortoisehg to use it (and thus makeicns) in r82557. The icon is not perfect -- when you launch the app, the icon changes in the Dock -- but I guess it's better than nothing.

I'll leave this ticket open because I have not yet looked at the ssh-askpass situation at all.

[jmroot (Joshua Root)]

-> nomaintainer

[seanfarley (Sean Farley)]

This is fixed in the new version of TortoiseHG