Opened 13 years ago

Closed 12 years ago

Last modified 11 years ago

#29839 closed enhancement (fixed)

fish @1.23.1 Random delay

Reported by: fran6co@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch Cc: cooljeanius (Eric Gallager)
Port: fish

Description

Sometimes fish freezes for 5 seconds approx. Found a solution here http://ilia.mikhailov.se/post/274790894/fix-fish-shell-freeze-problem-on-osx-in-macports

I made a patch for this issue

Attachments (4)

Portfile-fish.diff (381 bytes) - added by fran6co@… 13 years ago.
patch-fix-freeze.diff (303 bytes) - added by fran6co@… 13 years ago.
Portfile-fish.2.diff (770 bytes) - added by BlackFrog1 13 years ago.
The correct diff file for the patch.
patch-proc.c.diff (303 bytes) - added by BlackFrog1 13 years ago.
the correct diff file for patching the source

Download all attachments as: .zip

Change History (9)

Changed 13 years ago by fran6co@…

Attachment: Portfile-fish.diff added

Changed 13 years ago by fran6co@…

Attachment: patch-fix-freeze.diff added

comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added

I see that patch is over a year and a half old. Have the developers of fish offered any input about whether this fix is correct, and if so, why they have not released a new version including this fix?

comment:2 Changed 13 years ago by fran6co@…

It seems that nobody is working on fish currently, the last version was released March 8, 2009. Also I'm not sure that this patch is required for other platforms too, for example in Linux it is working out of the box without any problem.

comment:3 Changed 13 years ago by BlackFrog1

fran6co, when creating a patch file, please follow the Creating Portfile Patches and Creating Source Code Patches in the guide.

I have add the correct patch files.

Changed 13 years ago by BlackFrog1

Attachment: Portfile-fish.2.diff added

The correct diff file for the patch.

Changed 13 years ago by BlackFrog1

Attachment: patch-proc.c.diff added

the correct diff file for patching the source

comment:4 Changed 12 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed

comment:5 Changed 11 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

Note: See TracTickets for help on using tickets.