Opened 18 years ago

Closed 18 years ago

Last modified 16 years ago

#299 closed defect (fixed)

contents list sorting needed

Reported by: jpm@… Owned by: jpm@…
Priority: Normal Milestone:
Component: base Version: 1.0
Keywords: Cc:
Port:

Description

say the main contents list is:

contents \

a/1 \ a/2 \ a \ b/5 \ b

and a variant also installs the file 'a/3' and uses:

contents-append \

a/3

when the contents list is created, it is not sorted and 'a/3' is tacked on the end. uninstall failures can avalanche from this implementation detail. obviously this is a simple case but it can save needing to create several contents list for a single differing line...

Attachments (1)

portuninstall.tcl.diff (690 bytes) - added by jpm@… 18 years ago.
adds contents list ordering at uninstall

Download all attachments as: .zip

Change History (3)

comment:1 Changed 18 years ago by jpm@…

Status: newassigned

think i have this one nailed:

portuninstall.tcl:85 set contents [lsort -decreasing [lindex $entry [incr ix]]]

this should be able to handle all sorts of contents list mayhem. i need to test this more before i submit it for review but in my shallow tests it has handled all out-of-order contents registrations i have thrown its way.

with this change, port maintainers do not need to worry about the order their port elements are registered. while good practice it will no longer cause uninstall failures....

Changed 18 years ago by jpm@…

Attachment: portuninstall.tcl.diff added

adds contents list ordering at uninstall

comment:2 Changed 18 years ago by jpm@…

Resolution: fixed
Status: assignedclosed

patch merged 08:08 GMT/UTC 2003/01/14

Note: See TracTickets for help on using tickets.