Opened 13 years ago
Closed 13 years ago
#29901 closed enhancement (fixed)
libmilter +universal
| Reported by: | pixilla (Bradley Giesbrecht) | Owned by: | danielluke (Daniel J. Luke) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 1.9.2 |
| Keywords: | haspatch | Cc: | danielluke (Daniel J. Luke) |
| Port: | libmilter |
Description
Have libmilter build universal.
Attachments (2)
Change History (6)
Changed 13 years ago by pixilla (Bradley Giesbrecht)
| Attachment: | patch-Portfile.diff added |
|---|
comment:1 follow-up: 2 Changed 13 years ago by jmroot (Joshua Root)
Changed 13 years ago by pixilla (Bradley Giesbrecht)
| Attachment: | patch-Portfile.2.diff added |
|---|
w/jmr fixes
comment:2 Changed 13 years ago by pixilla (Bradley Giesbrecht)
Replying to jmr@…:
Why remove
use_configure no?
To get free +universal variant.
Why the random whitespace removal?
Are referring to the empty line after "PortSystem" where I had added and removed PortGroup muniversal? If not, I don't see any random whitespace removal. I did intentionally remove the "platform darwin 10" block.
And shouldn't you still be doing the same thing but with configure.cc_archflags in the non-universal case?
I don't know, the port did not use them before.
Thank you for the feedback jmr, I have uploaded patch-Portfile.2.diff which I believe addresses each of these issues. More feedback is welcome.
comment:3 Changed 13 years ago by danielluke (Daniel J. Luke)
| Owner: | changed from macports-tickets@… to dluke@… |
|---|---|
| Status: | new → assigned |
comment:4 Changed 13 years ago by danielluke (Daniel J. Luke)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Looks good to me. Committed in r79776. Thanks!
Why remove
use_configure no? Why the random whitespace removal? And shouldn't you still be doing the same thing but with configure.cc_archflags in the non-universal case?