Opened 5 years ago

Closed 5 years ago

#29950 closed defect (fixed)

FreeImage 3.15.0 breaks universal build

Reported by: ejtttje@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch Cc: MarcusCalhoun-Lopez
Port: freeimage

Description (last modified by ryandesign (Ryan Schmidt))

Changeset [79508] removed the 'variant universal' section without adding a 'universal_variant yes' flag. Further, LDFLAGS was not picking up the configure.universal_ldflags when needed (probably due to specification in build.args?), so the build was dropping the fat binaries during the final link. So I've also added a line with the other universal reinplace settings to apply the configure.universal_ldflags to the Makefile.

Attachments (1)

freeimage-universal.diff (1.1 KB) - added by ejtttje@… 5 years ago.
patch to fix universal support for freeimage 3.15.0

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by ejtttje@…

patch to fix universal support for freeimage 3.15.0

comment:1 Changed 5 years ago by jmroot (Joshua Root)

  • Cc mcalhoun@… added

Why revision 7?

comment:2 Changed 5 years ago by ejtttje@…

Just took me 7 revisions to get it right... feel free to reset to 1 (starts at 0?) if that makes you feel dirty ;)

(Is there a better way to get MacPorts to reapply changes to a Portfile in a local port directory? I was just incrementing revision so I could re-run port upgrade.)

comment:3 Changed 5 years ago by jmroot (Joshua Root)

Just uninstall first or use port -n upgrade --force.

comment:4 Changed 5 years ago by ryandesign (Ryan Schmidt)

  • Description modified (diff)
  • Keywords haspatch added
  • Owner changed from macports-tickets@… to ryandesign@…
  • Status changed from new to assigned

comment:5 Changed 5 years ago by ryandesign (Ryan Schmidt)

Non-default build_arch doesn't actually work either.

comment:6 Changed 5 years ago by ryandesign (Ryan Schmidt)

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in r79850.

Note: See TracTickets for help on using tickets.