Opened 10 years ago

Closed 10 years ago

#30778 closed defect (fixed)

science/xmedcon sysgcc variant breaks portfile

Reported by: rmstonecipher@… Owned by: jameskyle@…
Priority: Normal Milestone:
Component: ports Version: 2.0.1
Keywords: Cc:
Port: xmedcon

Description

The sysgcc variant exists solely to allow +universal building; variants selected by default conflict with +universal in a manner which breaks the portfile entirely for users with +universal in variants.conf.

I would propose deleting the sysgcc variant and making the following substitution in the logic which currently fails to resolve the conflict between +universal and default behavior:

   -if {![variant_isset gcc43] && ![variant_isset sysgcc]} {
   +if {![variant_isset gcc43] && ![variant_isset universal]} {

Attachments (1)

Portfile.diff (1.8 KB) - added by rmstonecipher@… 10 years ago.
Proposed Portfile Changes

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by rmstonecipher@…

Breakdown of proposed changes:

  • Use glib2 path-style dependency port-wide rather than just in +gtk2 variant
  • Remove --enable-png configure argument (default behavior requires no argument)
  • Test for +universal rather than +sysgcc
  • Remove redundant glib2 dependency from +gtk2 variant - gtk2 depends on glib2
  • Remove redundant gtk1 dependency from +gtk1 variant - gdk-pixbuf depends on gtk1
  • Delete do-nothing variant +sysgcc and all references to it

James,
It looks like the original reason for using gcc43 (now gcc44) by default from the original 2008-11-08 port was for FORTRAN support.
Do users benefit from FORTRAN support enough justify the hours-long build time required for gcc44?
The system compiler works, so I would like to remove the logic that leads to +gcc44 as a default variant - I must be sure it's the right thing to do.

Cheers,
Ryan Stonecipher

P.S. I goofed a line before generating my .diff, replacement to be uploaded shortly

comment:2 Changed 10 years ago by rmstonecipher@…

I think the gcc43 and gcc44 variants should be removed at this time.
If a legacy platform encounters errors on the system compiler, I will attempt to resolve them.

The gtk2 GUI sure seems handy when this program has several pages of CLI options listed when one runs 'medcon --help'.
I think knocking out the gtk2 variant and making the GUI version default would be ok - it would take less time to build the full gtk2 kit-and-caboodle than it would to build either gcc.

Updated slim-and-trim Portfile.diff attached.

Changed 10 years ago by rmstonecipher@…

Attachment: Portfile.diff added

Proposed Portfile Changes

comment:3 Changed 10 years ago by rmstonecipher@…

Re-added gtk2 variant as a default variant per community suggestion to allow non-GUI installation (-gtk2) if desired.

comment:4 Changed 10 years ago by rmstonecipher@…

Resolution: fixed
Status: newclosed

Changes committed in r83673.

Note: See TracTickets for help on using tickets.