pianobar @2011.07.09_0 Segmentation fault

[grrr@…]

On Lion 10.7.1 pianobar builds, but does not run:

Welcome to pianobar (2011.07.09)! Press ? for a list of commands.
Segmentation fault: 11

Discussion of a fix: ​https://github.com/PromyLOPh/pianobar/issues/138

[jmroot (Joshua Root)]

Please remember to cc the maintainer.

[aguynamedryan+macports@…]

patch to grab latest commit to pianobar and fix "make install" case-insensitive file system problem

[aguynamedryan+macports@…]

Grrr! Thanks for pointing me to the fix and making this an easy update for me! I updated the Portfile to fetch the most recent commit from github.

Just as a note, I ran into a problem while working on this patch: "sudo port install pianobar" would _sometimes_ fail during the destroot phase. Turns out that I'm running a case-insensitive file system on Mac OS X. There is a file named "INSTALL" in pianobar's root directory and so "make install" do nothing because the INSTALL file is considered up to date. ​Mentioned Here ​and here

The temporary solution is to remove the INSTALL file in the pre-destroot phase ​as was done for smake at some point.

The permanent solution, as suggested to me by dports in the #MacPorts IRC channel, is to add declare install to be ​.PHONY in the Makefile like so:

.PHONY: install

This line tells make that the target "install" does not represent a file and so make will ignore the INSTALL file and run everytime!

I've submitted a pull-request to the upstream maintainer to fix the Makefile.

Anyway, I think this patch is ready for commit. I've got some tunes streaming through pianobar 2011.07.29 as we speak!

[mf2k (Frank Schima)]

r82695. I also removed the unnecessary quotes from the long_description.