Opened 13 years ago
Closed 13 years ago
#31001 closed enhancement (fixed)
swi-prolog, swi-prolog-devel, swi-prolog-lite: remove expat dependency on darwin 9
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | J.Wielemaker@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.0.1 |
| Keywords: | haspatch | Cc: | pmoura (Paulo Moura) |
| Port: | swi-prolog, swi-prolog-devel, swi-prolog-lite |
Description
In r31733 for #13461 a dependency on expat was added to swi-prolog for darwin 9 only. The title of the ticket says this was done "to fix build on Mac OS X 10.5 Leopard". The same was done for swi-prolog-devel in r42976 for #16964, and for swi-prolog-lite in r63856 for #23155.
I don't understand why it would need expat only on darwin 9, but not on darwin 8, darwin 10 or darwin 11. I just now installed the current version of swi-prolog on Leopard. The machine did have expat installed, but looking through the log, I see no mention of expat or xmlwf being used, and the installed files don't appear to be linked to libexpat. I also grepped the swi-prolog source and find no occurrences of "xmlwf". There are a few occurrences of "expat" but they either merely refer to the expat license, or are Mac OS X / MacPorts-specific documentation stating that expat is a dependency, without elaborating why.
Can this dependency be removed or is there some hidden use of expat exclusively on darwin 9 that I'm not seeing?
Attachments (1)
Change History (3)
Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | expat.diff added |
|---|
comment:1 follow-up: 2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Jan sent the following reply by email:
Although I'm owner, I do not have a login to Trac.
You can create one by clicking the Register button at the top right of this web page.
Anyway, SWI-Prolog has no direct dependency on expat. It might have gotten there because SWI-Prolog does depend on X11 fontconfig and older versions thereof had various issues. Maybe a dependency was added to SWI-Prolog to work around a broken dependency in fontconfig?
fontconfig has always declared a dependency on expat ever since the fontconfig port was created 8 years ago in r2665.
So can I apply the attached patch to remove the expat dependency from the swi-prolog ports?
comment:2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Replying to ryandesign@…:
So can I apply the attached patch to remove the expat dependency from the swi-prolog ports?
Jan sent this reply by email:
I think so.
So I committed in r83259.
proposed patch