Opened 13 years ago

Closed 12 years ago

#31158 closed update (fixed)

class-dump 3.3.4 update

Reported by: 0xced (Cédric Luthi) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: maintainer Cc: 0xced (Cédric Luthi), mklein-de (Michael Klein)
Port: class-dump

Description

I asked Waqar Malik — the current maintainer of the port — if he was OK for me to take ownership of the class-dump port and he said OK. So here is an updated class-dump 3.3.4 port.

Attachments (6)

Portfile (1.4 KB) - added by 0xced (Cédric Luthi) 13 years ago.
patch-dyld-info-compat.h.diff (1.3 KB) - added by 0xced (Cédric Luthi) 13 years ago.
v3.3.4.diff (1.5 KB) - added by 0xced (Cédric Luthi) 13 years ago.
spacing.diff (2.2 KB) - added by 0xced (Cédric Luthi) 13 years ago.
main.log (172.7 KB) - added by com-macosforge@… 12 years ago.
build error on 10.6.8
loader.h (62.0 KB) - added by girl@… 12 years ago.

Download all attachments as: .zip

Change History (16)

Changed 13 years ago by 0xced (Cédric Luthi)

Attachment: Portfile added

Changed 13 years ago by 0xced (Cédric Luthi)

comment:1 Changed 13 years ago by mf2k (Frank Schima)

Port: class-dump added
Version: 2.0.2

Please supply a unified diff of the Portfile. In the future, please fill in the Port field.

comment:2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

I looked at a diff between the existing portfile and your new one. You've changed the whitespace of the portfile, in addition to updating to version 3.3.4. These changes should be made separately. Provide a diff that makes only functional changes, then once that's committed, you can provide a second diff that makes only whitespace changes if desired. (Or the other way around, as you wish.)

You've also made the port require Snow Leopard or newer, whereas before it required Leopard or newer. I'm surprised the developers would increase the minimum system requirements in a bugfix release. Are you sure this port won't work on Leopard anymore?

Changed 13 years ago by 0xced (Cédric Luthi)

Attachment: v3.3.4.diff added

Changed 13 years ago by 0xced (Cédric Luthi)

Attachment: spacing.diff added

comment:3 Changed 13 years ago by 0xced (Cédric Luthi)

Here are two unified diffs, one for v3.3.4 update and one for fixing tabs to spaces, in that order.

And yes, class-dump 3.3.4 requires Snow Leopard.

comment:4 Changed 13 years ago by 0xced (Cédric Luthi)

Cc: cedric.luthi@… added

Cc Me!

Changed 12 years ago by com-macosforge@…

Attachment: main.log added

build error on 10.6.8

comment:5 Changed 12 years ago by com-macosforge@…

class-dump 3.3.4 isn't building on Snow Leopard either for me (see attachment).

comment:6 Changed 12 years ago by 0xced (Cédric Luthi)

Can you please upload your loader.h file located at /Developer/SDKs/MacOSX10.6.sdk/usr/include/mach-o/loader.h ? I have noticed that this file, part of the 10.6 SDK differs between different Xcode versions. I have Xcode 3.2.6, 4.1 and 4.2 and each time loader.h (all from the 10.6 SDK) is different! Also, please specify the exact version of Xcode installed in /Developer.

Changed 12 years ago by girl@…

Attachment: loader.h added

comment:7 Changed 12 years ago by girl@…

Hi Cedric, I am having the same build error on 10.6.8 -- am running version XCode Build version 4... if that helps.

comment:8 Changed 12 years ago by mklein-de (Michael Klein)

Cc: michael.klein@… added

Cc Me!

comment:9 Changed 12 years ago by 0xced (Cédric Luthi)

Well, I guess r84378 closes this ticket…

comment:10 Changed 12 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.