New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #31235 (closed update: fixed)

Opened 3 years ago

Last modified 3 years ago

libffi: update to 3.0.10

Reported by: ryandesign@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc: ak.ml@…
Port: libffi

Description

libffi should probably be updated to 3.0.10.

The patch we were using before doesn't seem to be needed anymore; I believe it was applied upstream on 2010-12-18.

Attached is a patch to update the port, and a log of what happens. It doesn't build at all. I don't know why.

Attachments

libffi-3.0.10.diff (2.8 KB) - added by ryandesign@… 3 years ago.
patch that does not work
main.log (15.2 KB) - added by ryandesign@… 3 years ago.
log of what happens
patch-configure.diff (1.8 KB) - added by ak.ml@… 3 years ago.

Change History

Changed 3 years ago by ryandesign@…

patch that does not work

Changed 3 years ago by ryandesign@…

log of what happens

Changed 3 years ago by ak.ml@…

comment:1 Changed 3 years ago by ak.ml@…

With patch-configure.diff, I could get libffi to compile. The explanation is that BSD wc and GNU wc have different outputs (BSD prepends spaces).

$ echo BSD | wc -w
       1
$ echo GNU | gwc -w
1

This breaks the following string comparison test "$n" = "0". I replaced it with a numerical comparison.

comment:2 Changed 3 years ago by ak.ml@…

  • Cc ak.ml@… added

Cc Me!

comment:3 follow-up: ↓ 4 Changed 3 years ago by ryandesign@…

  • Status changed from new to closed
  • Resolution set to fixed

Brilliant, thanks. Updated in r84201.

This part of the configure script actually comes from the included m4/ax_enable_builddir.m4; libffi 3.0.9 didn't have that file. I'll report the problem to the libffi-discuss mailing list, but we may also need to report it to the developers of ax_enable_builddir.m4.

comment:4 in reply to: ↑ 3 Changed 3 years ago by ryandesign@…

Note: See TracTickets for help on using tickets.