xorg-cf-files has a bad Concat3 macro (somehow gcc doesn't trip on it)

[takanori@…]

gcc doesn't like the Concat3 macro either, but it looks like it doesn't actually use it, probably because it's never called in gcc's cpp-path

[takanori@…]

Tested on Xcode 4.2 GM/Lion

[takanori@…]

This is because clang cannot interpret Concat3() macro properly which is declared in Imake.rules.

[takanori@…]

Patch to avoid this problem. I think this patch also fixes #30776, etc.

[takanori@…]

Committed in r84946.

[jmroot (Joshua Root)]

Have you filed a radar about this?

[takanori@…]

No, not yet.

I cannot tell whether this is a bug that should be reported or an expected behavior since I know next to nothing about llvm clang.. ;-(

[jeremyhu (Jeremy Huddleston Sequoia)]

I'm just hearing about this now as a result of ​https://bugs.freedesktop.org/show_bug.cgi?id=45509

PLEASE file radars or tell me about issues like this, so I can look into them and file radars if you don't want to. Switching compilers and ignoring the problem won't fix it if it's really a compiler issue.

[jeremyhu (Jeremy Huddleston Sequoia)]

imake itself is fine, so reverting this in r89535

The real fix lies outside imake (probably in xorg-cf-files), and if you want to work around it, do so in the ports that are using imake and failing because if this fixe them, then they're broken already in that they're not honoring ${configure.cc} properly.

[jeremyhu (Jeremy Huddleston Sequoia)]

These will actually work around the issue in canna: r89536 r89537

xorg-cf-files needs to be fixed

[anddam (Andrea D'Amore)]

Cc Me!

[jmgoicolea (Jose Goicolea)]

Cc Me!

[jmroot (Joshua Root)]

Partial fix and partial workaround committed in r93825. This at least allows imake-using stuff to build for me with Xcode 4.3.2. The patches should be OK to send upstream.

The reinplaces that put ${configure.cc} and friends into darwin.cf weren't really correct anyway, since the dependent ports may change the compiler and need to specify it individually.

I'm still not sure why clang ever hit the problem with Concat3, since it does define __STDC__ and so should have been taking the first branch.

[jmroot (Joshua Root)]

Looks like imake really needs -traditional-cpp for those macros so the whitespace comes out right. Since clang doesn't support that option, I've fixed it to use cpp instead of $CC -E in r93865.

[jmroot (Joshua Root)]

This will probably pop up again when llvm-gcc is removed from Xcode, since /usr/bin/cpp will presumably have to start using clang.

[howarth@…]

Note that upstream clang appears uninterested in enhancing their -traditional-cpp support and expects this to be fixed in the imake instead.
​http://lists.cs.uiuc.edu/pipermail/llvmdev/2013-February/058970.html

[jeremyhu (Jeremy Huddleston Sequoia)]

I am very much on top of this issue.

[cooljeanius (Eric Gallager)]

Cc Me!

[Ionic (Mihai Moldovan)]

This problem is now prevalent on Mavericks, as llvm-gcc has been removed. Hit it when rebuilding xcb.

[Ionic (Mihai Moldovan)]

Cc Me!

[jeremyhu (Jeremy Huddleston Sequoia)]

Please open a new ticket for your new issue.