Opened 8 years ago

Closed 8 years ago

#31562 closed update (fixed)

CGAL version bump 3.8 -> 3.9

Reported by: mamoll (Mark Moll) Owned by: Veence (Vincent)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: raphael-st (Raphael Straub), ryandesign (Ryan Schmidt), florian@…
Port: cgal

Description

I didn't check the demos variant. You might want to include the additional patch file, which makes sure that the cmake-related code is installed in a location that should be in cmake's module path.

Attachments (4)

Portfile.diff (1015 bytes) - added by mamoll (Mark Moll) 8 years ago.
patch-CMakeLists.txt.diff (520 bytes) - added by mamoll (Mark Moll) 8 years ago.
Portfile.2.diff (1.9 KB) - added by raphael-st (Raphael Straub) 8 years ago.
patch-CMakeLists.txt.2.diff (2.4 KB) - added by raphael-st (Raphael Straub) 8 years ago.

Download all attachments as: .zip

Change History (15)

Changed 8 years ago by mamoll (Mark Moll)

Attachment: Portfile.diff added

Changed 8 years ago by mamoll (Mark Moll)

Attachment: patch-CMakeLists.txt.diff added

comment:1 Changed 8 years ago by mamoll (Mark Moll)

Actually, ignore that second patch. You can just do this in the Portfile:

configure.args-append -DCGAL_INSTALL_CMAKE_DIR="${prefix}/lib/cmake"

comment:2 Changed 8 years ago by blb@…

Owner: changed from vince to vince@…

Assignees need to be complete email addresses.

comment:3 Changed 8 years ago by raphael-st (Raphael Straub)

I would propose the attached patch as the demos variant does not compile with llvm-gcc-4.2 and clang. The patch also fixes #29382. I also attached an updated patchfile for the CMakeLists.txt files for the demos.

But I still have one problem with CGAL 3.9. When compiling CGAL 3.9 the old CGAL 3.8 headers are picked up if CGAL 3.8 is still active. Here is the corresponding part of the build log:

:info:build [ 33%] Building CXX object src/Core/CMakeFiles/CGAL_Core.dir/all_files.cpp.o
:info:build cd /opt/local/var/macports/build/cgal/cgal/work/CGAL-3.9/src/Core && /usr/bin/g++-4.2   -DCGAL_Core_EXPORTS -pipe -O2 -arch ppc  -frounding-math -fno-strict-aliasing -O3 -DNDEBUG -arch ppc -isysroot / -mmacosx-version-min=10.5 -fPIC -I/opt/local/include -I/opt/local/var/macports/build/cgal/cgal/work/CGAL-3.9/include -I/opt/local/var/macports/build/cgal/cgal/work/CGAL-3.9/src/Core    -o CMakeFiles/CGAL_Core.dir/all_files.cpp.o -c /opt/local/var/macports/build/cgal/cgal/work/CGAL-3.9/src/Core/all_files.cpp
:info:build In file included from /opt/local/var/macports/build/cgal/cgal/work/CGAL-3.9/src/Core/all_files.cpp:1:
:info:build /opt/local/var/macports/build/cgal/cgal/work/CGAL-3.9/src/CGALCore/Expr.cpp: In member function ‘void CORE::Expr::doubleInterval(double&, double&) const’:
:info:build /opt/local/var/macports/build/cgal/cgal/work/CGAL-3.9/src/CGALCore/Expr.cpp:78: error: ‘CGAL_CORE_finite’ was not declared in this scope

So, I had to deactivate the old CGAL version before installing the new one.

Changed 8 years ago by raphael-st (Raphael Straub)

Attachment: Portfile.2.diff added

Changed 8 years ago by raphael-st (Raphael Straub)

Attachment: patch-CMakeLists.txt.2.diff added

comment:4 Changed 8 years ago by raphael-st (Raphael Straub)

Cc: raphael@… added

Cc Me!

comment:5 Changed 8 years ago by raphael-st (Raphael Straub)

Keywords: haspatch added
Version: 2.0.3

comment:6 Changed 8 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added
Resolution: fixed
Status: newclosed

comment:7 in reply to:  6 Changed 8 years ago by florian@…

Resolution: fixed
Status: closedreopened

Replying to ryandesign@…:

r87107

Are you sure this is fixed yet? I still have this issue, when I don't deactivate cgal@3.8_0 prior to upgrading:

[ 10%] Building CXX object src/Core/CMakeFiles/CGAL_Core.dir/all_files.cpp.o
cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gis_cgal/cgal/work/CGAL-3.9/src/Core && /usr/bin/g++-4.2   -DCGAL_Core_EXPORTS -pipe -O2 -arch x86_64  -frounding-math -fno-strict-aliasing -O3 -DNDEBUG -arch x86_64 -isysroot / -mmacosx-version-min=10.6 -fPIC -I/opt/local/include -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gis_cgal/cgal/work/CGAL-3.9/include -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gis_cgal/cgal/work/CGAL-3.9/src/Core    -o CMakeFiles/CGAL_Core.dir/all_files.cpp.o -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gis_cgal/cgal/work/CGAL-3.9/src/Core/all_files.cpp
In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gis_cgal/cgal/work/CGAL-3.9/src/Core/all_files.cpp:5:
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gis_cgal/cgal/work/CGAL-3.9/src/CGALCore/Expr.cpp: In member function ‘void CORE::Expr::doubleInterval(double&, double&) const’:
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_gis_cgal/cgal/work/CGAL-3.9/src/CGALCore/Expr.cpp:78: error: ‘CGAL_CORE_finite’ was not declared in this scope
make[2]: *** [src/Core/CMakeFiles/CGAL_Core.dir/all_files.cpp.o] Error 1
make[1]: *** [src/Core/CMakeFiles/CGAL_Core.dir/all] Error 2
make: *** [all] Error 2

comment:8 Changed 8 years ago by ryandesign (Ryan Schmidt)

You're right, I didn't address that part of the request. Deactivate cgal 3.8 before trying to build 3.9. I'll add a check to the portfile to make sure users do that.

comment:9 Changed 8 years ago by ryandesign (Ryan Schmidt)

Cc: florian@… added

comment:10 Changed 8 years ago by cobxo3bot@…

I had a problem with installing the upgrade. It was solved by deactivating the older version however.

comment:11 Changed 8 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.