Opened 12 years ago
Closed 12 years ago
#31745 closed defect (fixed)
ipe-tools: Please update pdftoipe to version 20110916 and apply patch for upstream issue 88 to make it compile against poplar 0.18.0
| Reported by: | maehne (Torsten Maehne) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.0.3 |
| Keywords: | pdftoipe poppler haspatch | Cc: | m.thon@… |
| Port: | ipe-tools |
Description
The ipe-tools port fails currently to build due to a compiler error in xmloutputdev.cpp of pdftoipe, which assumes DCTStream to be declared in String.h of the poppler library. This is only the case when poppler is compiled with an own JPEG decoder, instead of using libjpeg. The error appeared with the update of poppler to version 0.18.0. It has been reported upstream as issue #88 together with a patch, which hasn't been yet applied.
The attached updates to the Portfile of ipe-tools use the latest pdftoipe version 20110916, which is then fixed with the proposed patch. Additionally, I propose to update the dependency of svgtoipe from py26-pil to py27-pil to avoid the pulling in of python26. The svgtoipe tool seems to work fine with the newer version, too.
Attachments (5)
Change History (11)
Changed 12 years ago by maehne (Torsten Maehne)
| Attachment: | patch-ipe-tools-Portfile-pdftoipe-20110916.diff added |
|---|
Changed 12 years ago by maehne (Torsten Maehne)
| Attachment: | patch-pdftoipe-xmloutputdev.cpp.diff added |
|---|
Patch to xmloutputdev.cpp of pdftoipe-20110916 for poppler 0.18.0 compatibility
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Keywords: | haspatch added |
|---|
comment:2 Changed 12 years ago by m.thon@…
Thanks for the patch! I modified things slightly:
- I use the macports patchfiles option and a slightly modified patchfile instead of calling the patch command manually
- I added variants pythonXY which set the pil dependency to pyXY-pil accordingly. If no variants are specified, py27-pil is used. I don't know if this is a standard way of handling python dependencies. Perhaps the new python portgroup should be used instead?
The modified files Patchfile-ipe-tools.diff and patch-pdftoipe-20110916-src-xmloutputdev.cpp.diff are attached.
Changed 12 years ago by m.thon@…
| Attachment: | patch-pdftoipe-20110916-src-xmloutputdev.cpp.diff added |
|---|
modified source patch file
comment:3 Changed 12 years ago by maehne (Torsten Maehne)
@m_thon: The python variants are a good idea! However, I suggest to use the compiler variants recipe. See the the patch, I just attached to the ticket. Additionally, the patch also sets the license field and configures the text editor for correct Portfile formatting.
Changed 12 years ago by maehne (Torsten Maehne)
| Attachment: | Portfile-ipe-tools-with-python-variants.diff added |
|---|
Portfile patch with python variants following the compiler variants recipe
comment:4 Changed 12 years ago by m.thon@…
Yes, this definitely makes the variants more readable. You forgot to delete py27-pil as a global port dependency though. I uploaded a modified Portfile-ipe-tools.diff file.
comment:5 Changed 12 years ago by maehne (Torsten Maehne)
Thank you for spotting this bug in the port dependencies! I think now it is ready for integration in the official port tree. I hope someone with commit rights to the repository applies soon this patch and closes this bug report.
comment:6 Changed 12 years ago by dbevans (David B. Evans)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Changes committed in r86582, build confirmed against current poppler version 0.18.1.
Patch for ipe-tools Portfile to use pdftoipe 20110916