New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #31852 (closed enhancement: fixed)

Opened 2 years ago

Last modified 10 months ago

fontforge: add python variants

Reported by: michael@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc: suv-sf@…, mojca.miklavec.lists@…, patrick@…, derekathomas@…, jmaibaum@…
Port: fontforge

Description

This patch adds variants to the fontforge port for enabling Python support, both as a Python module and as an embedded scripting language. There are two (conflicting) variants, one for Python 2.6 and the other for Python 2.7.

Attachments

Portfile-fontforge.diff (1.3 KB) - added by michael@… 2 years ago.
patch-Makefile.dynamic.in.diff (2.6 KB) - added by michael@… 2 years ago.
patch-Makefile.dynamic.in.2.diff (2.6 KB) - added by jmaibaum@… 11 months ago.
New version reflecting jmr’s advices.
patch-Portfile.diff (1.3 KB) - added by jmaibaum@… 11 months ago.
New version reflecting jmr’s advices.

Change History

Changed 2 years ago by michael@…

Changed 2 years ago by michael@…

comment:1 Changed 2 years ago by ryandesign@…

  • Keywords haspatch added
  • Summary changed from Add Python support to FontForge to fontforge: add python variants

comment:2 Changed 2 years ago by michael@…

Any update on this? If this is not the right way to add a Python module, I would appreciate any hint on how to do it.

comment:3 Changed 2 years ago by suv-sf@…

  • Cc suv-sf@… added

Cc Me!

comment:4 Changed 2 years ago by mojca.miklavec.lists@…

  • Cc mojca.miklavec.lists@… added

Cc Me!

comment:5 Changed 2 years ago by patrick@…

  • Cc patrick@… added

Cc Me!

comment:6 Changed 22 months ago by jmr@…

Looks OK for the most part, but applicationsdir = /Applications is incorrect. The $applications_dir portfile variable needs to be inserted there.

Also might want to add --no-user-cfg to the setup.py args. And JFYI you don't need to use a separate configure.args-append call for each arg.

Note that comments on a ticket are only seen by the people on Cc (and the owner, when there is one). So you're much better off to ping the macports-dev list if a ticket seems to have been forgotten.

comment:7 Changed 20 months ago by derekathomas@…

  • Cc derekathomas@… added

Cc Me!

Changed 11 months ago by jmaibaum@…

New version reflecting jmr’s advices.

Changed 11 months ago by jmaibaum@…

New version reflecting jmr’s advices.

comment:8 Changed 11 months ago by jmaibaum@…

Hey,

I’ve tested Michaels patches for the python27 variant and they work fine.

jmr, I’ve checked the last versions of the patch Makefile.dynamic.in, the line change that adds the line:

applicationsdir = /Applications

is already in there since 5 years and gets, since then, reinplaced by the post-patch hook:

reinplace "/^applicationsdir/s|/Applications|${applications_dir}|" \ 
     ${worksrcpath}/Makefile.dynamic.in

Both these changes were introduced in changeset [42222].

So the only actual change that Michael introduced is the one in line 133.

I’ve attached two new patches that reflect jmr’s advices. Hopefully they can be committed soon, since programmatically calling fontforge from Python scripts is being used extensively in many new free font projects.

Cheers, jmaibaum.

comment:9 Changed 11 months ago by jmaibaum@…

  • Cc jmaibaum@… added

Cc Me!

comment:10 Changed 10 months ago by cal@…

  • Status changed from new to closed
  • Resolution set to fixed

In r106892, thanks for the patches.

Note: See TracTickets for help on using tickets.