Opened 7 years ago

Closed 7 years ago

#31933 closed defect (fixed)

sshfs depends upon openssh

Reported by: burdges@… Owned by: drkp (Dan Ports)
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: ssh sshfs openssh Cc:
Port: sshfs

Description

Apple has modified their ssh's behavior enough that installing macports' openssh breaks various now expected behaviors for the user interface, like using a gui askpass. I'd therefore recommend not forcing people to install the openssh package except when absolutely necessary.

It appears that sshfs compiles and runs fine after simply removing the port:openssh library dependency from .../ports/fuse/sshfs/Portfile. I'd therefore recommend that this modification.

Change History (4)

comment:1 Changed 7 years ago by pixilla (Bradley Giesbrecht)

burdges: can you supply some evidence?
What Mac OS X version?
What expected behaviors?
What gui askpass?

comment:2 Changed 7 years ago by burdges@…

There was a similar git-core ticket three years ago at #16911 which macports resolved by removing the dependency on openssh.

Apple started doing graphical ssh password prompts themselves around 10.6 if not before, but it's well integrated in 10.7. I personally dislike how Apple built ssh-askpass's functionality into ssh-agent and ssh itself, but it's convenient and it's now the expected behavior. Running otool -L /usr/bin/ssh-agent gives some idea what's going on without uninstalling the openssh macport.

Users must install SSHKeychain to emulate Apple's default behavior once openssh is installed.

comment:3 Changed 7 years ago by drkp (Dan Ports)

Owner: changed from macports-tickets@… to dports@…
Status: newassigned

comment:4 Changed 7 years ago by drkp (Dan Ports)

Resolution: fixed
Status: assignedclosed

Yes, sshfs just needs some version of openssh to be present, it doesn't have to be the MacPorts version. The path to ssh is also found at runtime, not (as far as I can tell) hardcoded into sshfs, so that's not a reason to require it either. I removed the dependency (or, more precisely, allowed /usr/bin/ssh to satisfy it) in r87241.

As a separate issue, if Apple's ssh and MacPorts's ssh behave differently, we may want to consider applying their patches to the port also.

Note: See TracTickets for help on using tickets.